From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 7/8] scripts/runqemu: remove redundant checking
Date: Sat, 20 Aug 2011 09:54:30 +0100 [thread overview]
Message-ID: <1313830470.24904.4.camel@lenovo.internal.reciva.com> (raw)
In-Reply-To: <512d2bd7cc7ad38f24b57fd8e0a73c8906cb4273.1313816148.git.otavio@ossystems.com.br>
On Sat, 2011-08-20 at 04:58 +0000, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> scripts/runqemu | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 91c3c9e..d617f79 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -163,7 +163,7 @@ while [ $i -le $# ]; do
> # A directory name is an nfs rootfs
> if [ -d "$arg" ]; then
> echo "Assuming $arg is an nfs rootfs"
> - if [[ -z "$FSTYPE" || "$FSTYPE" == "nfs" ]]; then
> + if [[ -z "$FSTYPE" ]]; then
> FSTYPE=nfs
> else
> echo "Error: conflicting FSTYPE types [$arg] and nfs"
Can you explain why this test is redundant? From inspection of the
patch it seems this would lead to "Error: conflicting FSTYPE types [nfs]
and nfs" if FSTYPE="nfs" to begin with. I guess there is some other
provision in the logic to make sure that this can't happen, but it would
be useful to have it explained in the checkin message.
p.
next prev parent reply other threads:[~2011-08-20 8:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 4:58 [PATCH 0/8] Pending patches from O.S. Systems tree Otavio Salvador
2011-08-20 4:58 ` [PATCH 1/8] Use OECORE_DISTRO_VERSION instead of POKY_DISTRO_VERSION Otavio Salvador
2011-08-20 4:58 ` [PATCH 2/8] kernel.bbclass: blacklist perf-dbg Otavio Salvador
2011-08-22 18:29 ` Saul Wold
2011-08-22 18:53 ` Otavio Salvador
2011-08-20 4:58 ` [PATCH 3/8] kernel.bbclass: move uboot image generation to a specific class Otavio Salvador
2011-08-20 5:07 ` Bruce Ashfield
2011-08-20 5:12 ` Otavio Salvador
2011-08-20 12:48 ` Bruce Ashfield
2011-08-20 22:14 ` Andrea Adami
2011-08-20 4:58 ` [PATCH 4/8] kernel.bbclass: save kernel image name into $kerneldir Otavio Salvador
2011-08-20 4:58 ` [PATCH 5/8] fix SDK building due TARGET_ARCH use in installation path Otavio Salvador
2011-08-22 21:58 ` Saul Wold
2011-08-23 11:54 ` Otavio Salvador
2011-08-20 4:58 ` [PATCH 6/8] scripts/runqemu: add support to pass bootparams to kernel Otavio Salvador
2011-08-20 4:58 ` [PATCH 7/8] scripts/runqemu: remove redundant checking Otavio Salvador
2011-08-20 8:54 ` Phil Blundell [this message]
2011-08-24 17:00 ` Otavio Salvador
2011-08-20 4:58 ` [PATCH 8/8] scripts/combo-layer: fix configuration file handling Otavio Salvador
2011-08-24 3:56 ` [PATCH 0/8] Pending patches from O.S. Systems tree Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313830470.24904.4.camel@lenovo.internal.reciva.com \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox