Re: [PATCH] utils.bbclass: skip empty paths when handling FILESEXTRAPATHS

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2011-08-24 at 17:20 -0700, Chris Larson wrote:
> On Wed, Aug 24, 2011 at 5:16 PM, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
> > On Thursday 25 August 2011 00:16:40 Chris Larson wrote:
> >> I strongly disagree with this. The fact is, we almost never go back
> >> and "clean these up later", so crap accrues.
> >
> > We're talking about the difference between:
> >
> > if a = "":
> >
> > and
> >
> > if a:
> >
> > This is not crap, it's a triviality (for the case where the functional
> > difference is not important anyway). If you care then by all means submit a
> > patch to change it.
> 
> Yes, this example is trivial, but its just one of many instances of
> this sort of code going in. I'd rather get the code clean to begin
> with, rather than letting crap pile up and never do anything about it.
> But I realize I care more about code quality than most of the people
> in this project.

I'm not sure that is true, I think many people care about the code
quality of OE. Quality means different things to different people. We
also all have different priorities. It would be nice in many ways if our
biggest worry was these sorts of issues but it isn't.

Also, we have a lot of new people looking at the project and starting to
contribute. People are learning a lot and becoming very skilled
developers, its exiting to watch some of their skill sets grow. Taking
an all or nothing approach to accepting patches tends to be
counterproductive. Educating people over time tends to work well.

I think these things will get addressed and get better in general over
time (and by many measures quality is improving already).

Cheers,

Richard