Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] libc-package bbclass: fix binary localedata dependency code
Date: Thu, 25 Aug 2011 10:24:45 +0100	[thread overview]
Message-ID: <1314264296.19905.29.camel@phil-desktop> (raw)
In-Reply-To: <1314210721-29941-1-git-send-email-koen@dominion.thruhere.net>

On Wed, 2011-08-24 at 20:32 +0200, Koen Kooi wrote:
> diff --git a/meta/classes/libc-package.bbclass b/meta/classes/libc-package.bbclass
> index 0d5ce20..d3b33d6 100644
> --- a/meta/classes/libc-package.bbclass
> +++ b/meta/classes/libc-package.bbclass
> @@ -243,7 +243,7 @@ python package_do_split_gconvs () {
>  	def output_locale_binary_rdepends(name, pkgname, locale, encoding):
>  		m = re.match("(.*)_(.*)", name)
>  		if m:
> -			libc_name = "%s.%s" % (m.group(1), m.group(2).lower().replace("-",""))
> +			libc_name = "%s-%s" % (m.group(1), m.group(2).lower().replace("-",""))
>  		else:
>  			libc_name = name
>  		bb.data.setVar('RDEPENDS_%s' % pkgname, legitimize_package_name('%s-binary-localedata-%s' \

For what it's worth (probably not much), this is not quite the right
fix.  Joining with "." was correct; it was the splitting on "_" that was
wrong.  The right thing would be to put it back how it was before the
glibc/eglibc merge commit, i.e. change the re to "(*.)\.(*.)" and leave
the output pattern alone.  That ought to fix your problem and also allow
the encoding to be correctly canonicalised.

p.





  parent reply	other threads:[~2011-08-25  9:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 18:32 [PATCH 1/2] libc-package bbclass: fix binary localedata dependency code Koen Kooi
2011-08-24 18:32 ` [PATCH 2/2] tcl: fix networking breakage Koen Kooi
2011-08-24 18:36   ` Saul Wold
2011-08-24 19:45     ` Koen Kooi
2011-08-25  2:26 ` [PATCH 1/2] libc-package bbclass: fix binary localedata dependency code Richard Purdie
2011-08-25  9:24 ` Phil Blundell [this message]
2011-08-25 14:58   ` Richard Purdie
2011-08-26 14:12     ` Phil Blundell
2011-08-26 14:54       ` Koen Kooi
2011-08-26 15:26       ` Koen Kooi
2011-08-26 15:30         ` Phil Blundell
2011-08-26 16:31           ` Koen Kooi
2011-08-30  9:26             ` Phil Blundell
2011-08-31 13:47               ` Koen Kooi
2011-08-31 17:05               ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314264296.19905.29.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox