Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 02/10] eglibc-package: don't fail without localedef/gconv
Date: Fri, 26 Aug 2011 11:12:43 +0100	[thread overview]
Message-ID: <1314353564.19905.81.camel@phil-desktop> (raw)
In-Reply-To: <cd4a85ccaa27bdd77ad06d9300ac71bd6b27e36d.1311195893.git.Martin.Jansa@gmail.com>

On Wed, 2011-07-20 at 23:06 +0200, Martin Jansa wrote:
>-       mv ${D}${libdir}/gconv ${dest}${libdir}
> +	if [ -f ${D}${libdir}/gconv ]; then
> +		mv -f ${D}${libdir}/gconv ${dest}${libdir}
> +	fi

This can't be right: gconv will be a directory if it exists at all and
hence "test -f gconv" will never be true.

Since this patch was applied I'm getting a whole bunch of "installed but
not shipped" warnings for /lib/gconv/*.  Could you please look into
that?

thanks

p.





  reply	other threads:[~2011-08-26 10:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 21:06 [PATCH 00/10] Small fixes Martin Jansa
2011-07-20 21:06 ` [PATCH 01/10] tcmode-default: set preferred version also for (e)glibc-locale Martin Jansa
2011-07-20 21:06 ` [PATCH 02/10] eglibc-package: don't fail without localedef/gconv Martin Jansa
2011-08-26 10:12   ` Phil Blundell [this message]
2011-08-26 11:31     ` Martin Jansa
2011-08-26 11:41       ` [PATCH] eglibc: fix gconv packaging after 5486cac29db6e67051fff7637a0abc9aeab661e5 Martin Jansa
2011-08-29 13:09         ` Richard Purdie
2011-07-20 21:06 ` [PATCH 03/10] intltool: inherit perlnative Martin Jansa
2011-07-21  5:35   ` Frans Meulenbroeks
2011-07-20 21:06 ` [PATCH 04/10] polkit: " Martin Jansa
2011-07-20 21:14   ` Phil Blundell
2011-07-20 21:06 ` [PATCH 05/10] shared-mime-info: " Martin Jansa
2011-07-20 21:06 ` [PATCH 06/10] xkeyboard-config: " Martin Jansa
2011-07-20 21:06 ` [PATCH 07/10] avahi: " Martin Jansa
2011-07-20 21:06 ` [PATCH 08/10] vte: " Martin Jansa
2011-07-20 21:06 ` [PATCH 09/10] python: save Makefile.sysroot in do_compile Martin Jansa
2011-07-20 21:06 ` [PATCH 10/10] python: add patch to fix cross compilation on host with linux-3.0 Martin Jansa
2011-07-20 22:02 ` [PATCH 00/10] Small fixes Tom Rini
2011-07-21  2:03   ` Saul Wold
2011-07-21  0:18 ` Khem Raj
2011-07-21  0:54   ` Tom Rini
2011-07-21  6:11     ` Martin Jansa
2011-07-21  9:39       ` Richard Purdie
2011-07-21 16:44         ` Khem Raj
2011-07-21 21:54           ` Richard Purdie
2011-07-21 14:28       ` Tom Rini
2011-07-21 14:53         ` Martin Jansa
2011-07-21 15:35           ` Tom Rini
2011-07-22 15:32 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314353564.19905.81.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox