Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] busybox: import the configuration from openembedded.dev
Date: Mon, 05 Sep 2011 17:04:28 +0100	[thread overview]
Message-ID: <1315238669.2519.21.camel@phil-desktop> (raw)
In-Reply-To: <1315237881-14077-1-git-send-email-denis@eukrea.com>

On Mon, 2011-09-05 at 17:51 +0200, Denis Carikli wrote:
> Without that patch many applets are not build, like for instance
>   mdev, which could be necessary for building certain images.

If your distro needs mdev then you should probably supply your own
busybox config which turns it on.  For modern kernels mdev is probably
redundant since you will usually be better off with devtmpfs.

Or, conversely, if you feel that a particular change is important enough
that it really needs to go into the global busybox config for oe-core,
please send a patch which makes just that one change.  The patch you
sent flips a large set of of seemingly-random switches, for example:

@@ -85,14 +82,12 @@ CONFIG_FEATURE_FAST_TOP=y
 CONFIG_FEATURE_EDITING=y
 CONFIG_FEATURE_EDITING_MAX_LEN=1024
 # CONFIG_FEATURE_EDITING_VI is not set
-CONFIG_FEATURE_EDITING_HISTORY=15
+CONFIG_FEATURE_EDITING_HISTORY=64
 CONFIG_FEATURE_EDITING_SAVEHISTORY=y
 CONFIG_FEATURE_TAB_COMPLETION=y
 CONFIG_FEATURE_USERNAME_COMPLETION=y
 CONFIG_FEATURE_EDITING_FANCY_PROMPT=y
-# CONFIG_FEATURE_EDITING_ASK_TERMINAL is not set
-CONFIG_FEATURE_NON_POSIX_CP=y
-# CONFIG_FEATURE_VERBOSE_CP_MESSAGE is not set
+CONFIG_FEATURE_VERBOSE_CP_MESSAGE=y
 CONFIG_FEATURE_COPYBUF_KB=4
 CONFIG_MONOTONIC_SYSCALL=y
 CONFIG_IOCTL_HEX2STR_ERROR=y
@@ -105,7 +100,7 @@ CONFIG_FEATURE_HWIB=y
 #
 # Archival Utilities
 #
-CONFIG_FEATURE_SEAMLESS_LZMA=y
+# CONFIG_FEATURE_SEAMLESS_LZMA is not set
 CONFIG_FEATURE_SEAMLESS_BZ2=y
 CONFIG_FEATURE_SEAMLESS_GZ=y
 CONFIG_FEATURE_SEAMLESS_Z=y

... which is impossible to review sensibly, and it isn't at all obvious
why this new configuration would necessarily be an improvement.

p.





  reply	other threads:[~2011-09-05 16:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 15:51 [PATCH] busybox: import the configuration from openembedded.dev Denis Carikli
2011-09-05 16:04 ` Phil Blundell [this message]
2011-09-05 16:13   ` Eric Bénard
2011-09-05 16:05 ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315238669.2519.21.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox