From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/1] Fix MakeMaker's finding of perl.real
Date: Wed, 07 Sep 2011 23:42:42 +0100 [thread overview]
Message-ID: <1315435362.13021.53.camel@ted> (raw)
In-Reply-To: <20110907090750.GE4181@chargestorm.se>
On Wed, 2011-09-07 at 11:07 +0200, Anders Darander wrote:
> * Eric Bénard <eric@eukrea.com> [110907 08:41]:
> > Le 07/09/2011 07:09, Saul Wold a écrit :
> > > When configuring cpan packages, the directories passed to MakeMaker are the
> > > target directories. There was a patch that was applied to the native perl
> > > to find perl.real and convert that to perl. This does not apply for the
> > > target perl modules and therefore MakeMaker find perl.real.
> > >
> > > This patch to cpan configure modifies the Makefile after configure and
> > > changes the perl.real to just straight perl so we have the correct paths
> > > and shared state info in usable.
> > >
> > when sending 1 patch, is it possible to not use cover letter in order to have
> > the explanation in the patch commit ?
> > That's easier to understand what the patch is doing when browsing log.
>
> Cover letter or not, the patch should include a commit message that
> explains the patch. It doesn't really matter if there is only one patch
> or a large patch series.
>
> For a single patch, the cover letter can be usefull to provide some
> extra information and discussion. In other cases, it can be pretty
> useless IMHO.
This commit has slipped into the tree this time but I agree in future
more explanation of a commit is needed...
Cheers,
Richard
prev parent reply other threads:[~2011-09-07 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 5:09 [PATCH 0/1] Fix MakeMaker's finding of perl.real Saul Wold
2011-09-07 5:09 ` [PATCH 1/1] cpan.bbclass: fix native perl issue Saul Wold
2011-09-07 6:38 ` [PATCH 0/1] Fix MakeMaker's finding of perl.real Eric Bénard
2011-09-07 9:07 ` Anders Darander
2011-09-07 22:42 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315435362.13021.53.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox