From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] freetype: disable bzip2 compressed font support
Date: Mon, 19 Sep 2011 14:06:01 +0100 [thread overview]
Message-ID: <1316437569.14488.15.camel@ted> (raw)
In-Reply-To: <20110919110728.GA31160@mi.fu-berlin.de>
On Mon, 2011-09-19 at 13:07 +0200, Henning Heinold wrote:
> On Mon, Sep 19, 2011 at 11:58:36AM +0100, Paul Eggleton wrote:
> > If we do not disable this then it is enabled sometimes and disabled at
> > others depending on whether bzip2 has been built at the time, and worst
> > case it will cause a race condition if bzip2 is building at the same
> > time.
> >
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> > meta/recipes-graphics/freetype/freetype_2.4.6.bb | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-graphics/freetype/freetype_2.4.6.bb b/meta/recipes-graphics/freetype/freetype_2.4.6.bb
> > index 8150dd4..94a389a 100644
> > --- a/meta/recipes-graphics/freetype/freetype_2.4.6.bb
> > +++ b/meta/recipes-graphics/freetype/freetype_2.4.6.bb
> > @@ -13,7 +13,7 @@ LIC_FILES_CHKSUM = "file://docs/LICENSE.TXT;md5=28d5381b1bef2649c59f20c20bae4f39
> >
> > SECTION = "libs"
> >
> > -PR = "r0"
> > +PR = "r1"
> >
> > SRC_URI = "${SOURCEFORGE_MIRROR}/freetype/freetype-${PV}.tar.bz2 \
> > file://no-hardcode.patch"
> > @@ -28,7 +28,7 @@ inherit autotools pkgconfig binconfig
> > LIBTOOL = "${S}/builds/unix/${HOST_SYS}-libtool"
> > EXTRA_OEMAKE = "'LIBTOOL=${LIBTOOL}'"
> > EXTRA_OEMAKE_virtclass-native = ""
> > -EXTRA_OECONF = "--without-zlib"
> > +EXTRA_OECONF = "--without-zlib --without-bzip2"
> >
> > do_configure() {
> > cd builds/unix
>
> Hi,
>
> wouldn't it been better to let freetype depend on bz2 and libz. It may save some space in particular situations for some
> people.
Likely we should compress the fonts but this patch at least makes the
build deterministic. I'd probably take a further patch allowing
compression although whether it would make the release at this stage I'm
not sure.
Cheers,
Richard
next prev parent reply other threads:[~2011-09-19 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 10:58 [PATCH 0/3] Dependency fixes Paul Eggleton
2011-09-19 10:58 ` [PATCH 1/3] libgcrypt: add libcap to DEPENDS Paul Eggleton
2011-09-19 10:58 ` [PATCH 2/3] libgnome-keyring: add libgcrypt " Paul Eggleton
2011-09-19 10:58 ` [PATCH 3/3] freetype: disable bzip2 compressed font support Paul Eggleton
2011-09-19 11:07 ` Henning Heinold
2011-09-19 13:06 ` Richard Purdie [this message]
2011-09-19 12:14 ` [PATCH 0/3] Dependency fixes Richard Purdie
2011-09-19 14:01 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316437569.14488.15.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox