From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ey0-f175.google.com ([209.85.215.175]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1R6Ro6-0001Wz-LD for openembedded-core@lists.openembedded.org; Wed, 21 Sep 2011 20:46:06 +0200 Received: by mail-ey0-f175.google.com with SMTP id 25so1988646eya.6 for ; Wed, 21 Sep 2011 11:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=rSzaQJesZeFdvnJKnLsGHf/1bjY0uPdFcP19SsopFH8=; b=CWgIZrDbL3z8KZKUETSgU1qWrfzAGMtegjXY3Q6cQuw2eLG5aL7vf6Mj4lR/kIxlr7 ABb9FbterDbDlooi0J0ipPh77MO+ojqGafv4G2d29H5FDmFqnSGQBsfgMdNf5ZCrYJj9 ABr9peErtt5rXyb/I8tLQyMI1MP85zvapB2UE= Received: by 10.204.132.65 with SMTP id a1mr817154bkt.216.1316630445744; Wed, 21 Sep 2011 11:40:45 -0700 (PDT) Received: from localhost.localdomain ([194.85.238.22]) by mx.google.com with ESMTPS id t16sm5806554bkv.11.2011.09.21.11.40.44 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 21 Sep 2011 11:40:45 -0700 (PDT) From: Dmitry Eremin-Solenikov To: openembedded-core@lists.openembedded.org Date: Wed, 21 Sep 2011 22:40:04 +0400 Message-Id: <1316630404-10336-17-git-send-email-dbaryshkov@gmail.com> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1316630404-10336-1-git-send-email-dbaryshkov@gmail.com> References: <1316630404-10336-1-git-send-email-dbaryshkov@gmail.com> Cc: Dmitry Eremin-Solenikov Subject: [PATCH 17/17] package.bbclass: make unshipped files a fatal error X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2011 18:46:10 -0000 I belive that "files were installed but not shipped in any package" message should become a fatal error. While it's true that sometimes some files are generated by do_install task, which aren't necessary for our target systems. However in generic I think this is a very important and usually overlooked QA sign. E.g. recently I've found/fixed some bugs in eglibc packaging only due to making this a fatal error. Sometimes new versions of a software add new files, but then they are sometimes ignored, as this messages can be easily missed. You can come with more examples if you'd like to. Signed-off-by: Dmitry Eremin-Solenikov --- meta/classes/package.bbclass | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index a9c510d..f4a535e 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -948,6 +948,7 @@ python populate_packages () { bb.warn("For recipe %s, the following files were installed but not shipped in any package:" % pn) for f in unshipped: bb.warn(" " + f) + bb.fatal("Unshipped files found") bb.build.exec_func("package_name_hook", d) -- 1.7.2.5