From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dan.rpsys.net ([93.97.175.187]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1R6cES-0001FA-PH for openembedded-core@lists.openembedded.org; Thu, 22 Sep 2011 07:54:00 +0200 Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.2/8.14.2/Debian-2build1) with ESMTP id p8M5ssnO022816; Thu, 22 Sep 2011 06:54:54 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i0ZIdqeGZPGH; Thu, 22 Sep 2011 06:54:54 +0100 (BST) Received: from [10.251.10.153] ([192.102.205.10]) (authenticated bits=0) by dan.rpsys.net (8.14.2/8.14.2/Debian-2build1) with ESMTP id p8M5siuW022811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 22 Sep 2011 06:54:49 +0100 From: Richard Purdie To: Patches and discussions about the oe-core layer Date: Thu, 22 Sep 2011 06:48:24 +0100 In-Reply-To: <1316630404-10336-17-git-send-email-dbaryshkov@gmail.com> References: <1316630404-10336-1-git-send-email-dbaryshkov@gmail.com> <1316630404-10336-17-git-send-email-dbaryshkov@gmail.com> X-Mailer: Evolution 3.1.91- Message-ID: <1316670516.13622.30.camel@ted> Mime-Version: 1.0 Cc: Dmitry Eremin-Solenikov Subject: Re: [PATCH 17/17] package.bbclass: make unshipped files a fatal error X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2011 05:54:01 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2011-09-21 at 22:40 +0400, Dmitry Eremin-Solenikov wrote: > I belive that "files were installed but not shipped in any package" > message should become a fatal error. While it's true that sometimes some > files are generated by do_install task, which aren't necessary for our > target systems. However in generic I think this is a very important and > usually overlooked QA sign. E.g. recently I've found/fixed some bugs in > eglibc packaging only due to making this a fatal error. Sometimes new > versions of a software add new files, but then they are sometimes > ignored, as this messages can be easily missed. You can come with more > examples if you'd like to. > > Signed-off-by: Dmitry Eremin-Solenikov > --- > meta/classes/package.bbclass | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass > index a9c510d..f4a535e 100644 > --- a/meta/classes/package.bbclass > +++ b/meta/classes/package.bbclass > @@ -948,6 +948,7 @@ python populate_packages () { > bb.warn("For recipe %s, the following files were installed but not shipped in any package:" % pn) > for f in unshipped: > bb.warn(" " + f) > + bb.fatal("Unshipped files found") > > bb.build.exec_func("package_name_hook", d) One of thee post-release things I want to sort out is the QA warnings and I add this warning under that category. We introduced the ideas of warnings to error and warn on into the QA class already and I'd like to be able to control this warning in that way using the same variables. Also, rather than being bb.fatal, this should be bb.error. An Error message will allow the build to complete but will set the bitbake exit code to show when errors have occurred. This means errors still light the autobuilder up red when they occur so we're usually pretty good about noticing and removing error messages. Cheers, Richard