Re: [PATCH 0/3] [RFC] enable Pegasus touch screen

[Tom Zanussi <tom.zanussi@intel.com>]

On Mon, 2011-09-26 at 18:03 -0700, Zhai, Edwin wrote:
> From: Zhai Edwin <edwin.zhai@intel.com>
> 
> Tom,
> These changes, based on meta-intel/tzanussi/pegasus, are needed to enable
> eGalax touch screen on Pegasus. Could you pls. help to review?
> 

Hi Edwin,

First, I don't think this is the correct list for meta-intel stuff,
please use the yocto list.

Anyway, the first two patches look ok to me, but the 3rd seems to be a
combination of what it says in the title, enabling touch screen kernel
config, and updating the BSP to work with the current kernel recipes.
The latter should I think be squashed into the base BSP, which isn't
posted.

> When will you push Pegasus changes into meta-intel/master? We can have a common
> place for people to try pegasus...
> 

The meta-pegasus you pointed to seems to be an old version, basically
the same prototype version I gave you for the demo.  I thought the
current one had been updated to address the comments from the quick
review of Aug 9:

- meta-pegasus - commented-out stuff in pegasus.conf, xorg.conf,
linux-yocto-2.6.37.bbappend, ReleaseNotes are unrelated to the BSP, etc.

Also, it has a blacksand.pdf and has old kernel recipes, etc.

Basically, it needs to be cleaned up a bit before it can be pulled in,
and should be buildable without relying on later patches.

Also, I'm wondering if there's a reason it's using 2.6.37 - we're at 3.0
now, and it would be good if it used that.

Finally, please also add yourself or whoever will be the maintainer
going forward to meta-intel/MAINTAINERS...

Thanks,

Tom

> Thanks,
> Edwin
> 
> The following changes since commit 59dc67f6e64a836fc01fa91a1200e76264bb954d:
> 
>   meta-pegasus: new layer for Pegasus (N455) systems (2011-06-15 23:27:47 -0500)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib gzhai/pegasus
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/pegasus
> 
> Zhai Edwin (3):
>   eGalax touchscreen offical xorg driver
>   Config xorg.conf with eGalax touchscreen input driver
>   Enabled kernel module for eGalax touch screen.
> 
>  meta-pegasus/conf/machine/pegasus.conf             |    2 +-
>  .../xf86-input-egalax/88eGalaxCalibrate.sh         |    5 ++
>  .../xorg-driver/xf86-input-egalax_3.06.5605.bb     |   49 ++++++++++++++++++++
>  .../xserver-xf86-config/pegasus/xorg.conf          |   10 ++++
>  .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    2 +
>  .../recipes-kernel/linux/linux-yocto/pegasus.cfg   |    4 ++
>  .../linux/linux-yocto_2.6.37.bbappend              |   12 +++++
>  7 files changed, 83 insertions(+), 1 deletions(-)
>  create mode 100755 meta-pegasus/recipes-graphics/xorg-driver/xf86-input-egalax/88eGalaxCalibrate.sh
>  create mode 100644 meta-pegasus/recipes-graphics/xorg-driver/xf86-input-egalax_3.06.5605.bb
>  create mode 100644 meta-pegasus/recipes-kernel/linux/linux-yocto/pegasus.cfg
>  create mode 100644 meta-pegasus/recipes-kernel/linux/linux-yocto_2.6.37.bbappend
>