From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/4] conf, recipes: Add new variable LINKER_HASH_STYLE
Date: Wed, 28 Sep 2011 20:44:24 +0100 [thread overview]
Message-ID: <1317239072.12332.53.camel@ted> (raw)
In-Reply-To: <34fc595e22f0b359e6ae5ead10c1ecee30a447f6.1316138063.git.raj.khem@gmail.com>
On Thu, 2011-09-15 at 18:59 -0700, Khem Raj wrote:
> LINKER_HASH_STYLE in OE is set to either 'sysv' or 'gnu'
> depending upon processor architecture e.g. mips does not support
> gnu hash style so is uses sysv
>
> besides 'sysv' and 'gnu' third option is to set it to 'both' we do
> not do that by default but user can still set it
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/conf/bitbake.conf | 3 ++-
> meta/conf/distro/include/tcmode-default.inc | 6 +++++-
> meta/recipes-core/uclibc/uclibc.inc | 2 +-
> 3 files changed, 8 insertions(+), 3 deletions(-)
The build failure we're seeing on mips is related to this change. I'm
seeing this from "MACHINE=qemumips bitbake -e":
# LINKER_HASH_STYLE_mips64el=sysv
LINKER_HASH_STYLE_mips64el="sysv"
# LINKER_HASH_STYLE=sysv
LINKER_HASH_STYLE="sysv"
# LINKER_HASH_STYLE_mips64=sysv
LINKER_HASH_STYLE_mips64="sysv"
# TARGET_LINK_HASH_STYLE=${@['-Wl,--hash-style=gnu',''][bb.data.getVar('LINKER_HASH_STYLE', d, True) == 'gnu']}
TARGET_LINK_HASH_STYLE="-Wl,--hash-style=gnu"
# TARGET_LDFLAGS=-Wl,-O1 ${TARGET_LINK_HASH_STYLE} ${ASNEEDED}
export TARGET_LDFLAGS="-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed"
Obviously the problem is TARGET_LINK_HASH_STYLE is that value when
LINKER_HASH_STYLE="sysv" :/
We need to fix this...
Cheers,
Richard
next prev parent reply other threads:[~2011-09-28 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 1:59 [PATCH 0/4] Add eglibc 2.14 recipes and redo linker hashstyle patch Khem Raj
2011-09-16 1:59 ` [PATCH 1/4] conf, recipes: Add new variable LINKER_HASH_STYLE Khem Raj
2011-09-28 19:44 ` Richard Purdie [this message]
2011-09-28 21:24 ` Khem Raj
2011-09-28 22:41 ` Richard Purdie
2011-09-28 23:25 ` Khem Raj
2011-09-16 1:59 ` [PATCH 2/4] gcc-4.6: Use --with-linker-hash-style configure option Khem Raj
2011-09-16 1:59 ` [PATCH 3/4] eglibc-2.13: Replace oewarn with bbwarn Khem Raj
2011-09-16 1:59 ` [PATCH 4/4] eglibc: Add recipes for 2.14 Khem Raj
-- strict thread matches above, loose matches on Subject: below --
2011-09-27 3:39 [PATCH 0/4] Upgrade eglibc 2.14 and gcc 4.6 Khem Raj
2011-09-27 3:39 ` [PATCH 1/4] conf, recipes: Add new variable LINKER_HASH_STYLE Khem Raj
2011-09-28 13:40 ` Richard Purdie
2011-09-28 15:15 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317239072.12332.53.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox