From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: McClintock Matthew-B29882 <B29882@freescale.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 10/16] Fix mdadm for powerpc64
Date: Fri, 30 Sep 2011 17:29:43 +0100 [thread overview]
Message-ID: <1317400191.12332.211.camel@ted> (raw)
In-Reply-To: <CAEsOVNej5XjNzLnrxXVexEBj4xGDoVsrhSbzLZe71A4kpTWGWw@mail.gmail.com>
On Fri, 2011-09-30 at 15:51 +0000, McClintock Matthew-B29882 wrote:
> On Fri, Sep 30, 2011 at 6:38 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > That isn't quite what I meant, that also overwrites anything existing in
> > CXFLAGS just in a different way. Also, I suspect you mean CXXFLAGS?
> >
> > I'd meant something like:
> >
> > CXXFLAGS_append_powerpc64 = " -Wno-error=format"
>
> In the mdadm Makefile it gives the following instructions:
>
> # define "CXFLAGS" to give extra flags to CC.
> # e.g. make CXFLAGS=-O to optimise
>
> So I was following that...
Ok, normally we'd use CFLAGS for this but people love to be different
when writing makefiles :)
In that case your patch is fine...
Cheers,
Richard
next prev parent reply other threads:[~2011-09-30 16:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 18:52 [PATCH v2 10/16] Fix mdadm for powerpc64 Matthew McClintock
2011-09-30 11:38 ` Richard Purdie
2011-09-30 15:51 ` McClintock Matthew-B29882
2011-09-30 16:29 ` Richard Purdie [this message]
2011-10-03 19:22 ` Khem Raj
2011-10-03 21:14 ` McClintock Matthew-B29882
2011-10-03 21:17 ` Khem Raj
2011-10-04 21:52 ` McClintock Matthew-B29882
2011-10-05 11:34 ` Richard Purdie
2011-10-05 16:53 ` McClintock Matthew-B29882
2011-10-05 17:00 ` Richard Purdie
2011-10-05 19:21 ` Khem Raj
2011-10-05 21:15 ` McClintock Matthew-B29882
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317400191.12332.211.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=B29882@freescale.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox