From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dan.rpsys.net ([93.97.175.187]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RBPpk-0003L7-DZ for openembedded-core@lists.openembedded.org; Wed, 05 Oct 2011 13:40:20 +0200 Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.2/8.14.2/Debian-2build1) with ESMTP id p95BfBq1016461; Wed, 5 Oct 2011 12:41:12 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NtA3kkNBvaep; Wed, 5 Oct 2011 12:41:11 +0100 (BST) Received: from [192.168.1.40] (tim [93.97.173.237]) (authenticated bits=0) by dan.rpsys.net (8.14.2/8.14.2/Debian-2build1) with ESMTP id p95Bf8VQ016457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 5 Oct 2011 12:41:10 +0100 From: Richard Purdie To: McClintock Matthew-B29882 , Patches and discussions about the oe-core layer Date: Wed, 05 Oct 2011 12:34:37 +0100 In-Reply-To: References: <1317322353-30258-1-git-send-email-msm@freescale.com> <4E8A0B81.1080507@gmail.com> <4E8A2667.4090700@gmail.com> X-Mailer: Evolution 3.1.91- Message-ID: <1317814486.14671.136.camel@ted> Mime-Version: 1.0 Subject: Re: [PATCH v2 10/16] Fix mdadm for powerpc64 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2011 11:40:20 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2011-10-04 at 21:52 +0000, McClintock Matthew-B29882 wrote: > On Mon, Oct 3, 2011 at 4:17 PM, Khem Raj wrote: > >> I can't find a log of this anywhere, it's probably the default > >> compiler warnings for our platform are different? > > > > It would be handy to understand them since I dont see gcc differentiating > > formats between ppc64 and x86_64 which both are 64bit hosts. But obviously > > there is something missing. > > I finally got around to rerunning this without my patch and the errors > are below. I dug into this a bit. To quote asm/types.h: /* * This is here because we used to use l64 for 64bit powerpc * and we don't want to impact user mode with our change to ll64 * in the kernel. */ #if defined(__powerpc64__) && !defined(__KERNEL__) # include #else # include #endif So ppc64 kernel space uses ll64 and userspace uses l64. This means __u64 is a long for ppc64 but a long long for x86_64. The format errors occurs rightly because a ull is being printed from a ul variable. This will happen to work but its messy. Cheers, Richard