Re: [PATCH 2/6] Fix perl for powerpc64 build

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2011-10-04 at 17:03 -0500, Matthew McClintock wrote:
> Build environment for ARCH was set to powerpc on a powerpc64
> build, this adds an override to set this to powerpc64 when
> doing this type of build
> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
> No comments on original patch:
> 
> http://lists.linuxtogo.org/pipermail/openembedded-core/2011-September/010340.html
> 
>  meta/recipes-devtools/perl/perl_5.12.3.bb |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/perl/perl_5.12.3.bb b/meta/recipes-devtools/perl/perl_5.12.3.bb
> index e4769a4..d1ac0e8 100644
> --- a/meta/recipes-devtools/perl/perl_5.12.3.bb
> +++ b/meta/recipes-devtools/perl/perl_5.12.3.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
>  # We need gnugrep (for -I)
>  DEPENDS = "virtual/db grep-native"
>  DEPENDS += "gdbm zlib"
> -PR = "r5"
> +PR = "r6"
>  
>  # 5.10.1 has Module::Build built-in
>  PROVIDES += "libmodule-build-perl"
> @@ -95,6 +95,8 @@ export LDDLFLAGS = "${LDFLAGS} -shared"
>  # We're almost Debian, aren't we?
>  CFLAGS += "-DDEBIAN"
>  
> +export ARCH_powerpc64 = "powerpc64"
> +

I'm finding it really hard to believe this makes any difference. I just
tried a powerpc64 build here and perl built fine. I can't find any
evidence for any part of the perl build using an ARCH variable
(TARGET_ARCH is used but that isn't ARCH).

Can you give some further information about how/where this is used?

>  do_nolargefile() {
>  	sed -i -e "s,\(uselargefiles=\)'define',\1'undef',g" \
>  		-e "s,\(d_readdir64_r=\)'define',\1'undef',g" \
> @@ -156,7 +158,7 @@ do_configure() {
>              config.sh-${TARGET_ARCH}-${TARGET_OS}
>  
>  	case "${TARGET_ARCH}" in
> -		x86_64 | powerpc | s390)
> +		x86_64 | powerpc | powerpc64 | s390)
>  			sed -i -e "s,\(need_va_copy=\)'undef',\1'define',g" \
>  				config.sh-${TARGET_ARCH}-${TARGET_OS}
>  			;;

This bit is fine...

Cheers,

Richard