Re: [PATCH] xserver-xf86: Use PACKAGECONFIG for udev/hal choice and default to udev

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2011-10-06 at 16:29 +0200, Martin Jansa wrote:
> On Thu, Oct 06, 2011 at 03:21:33PM +0100, Richard Purdie wrote:
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xf86-common.inc b/meta/recipes-graphics/xorg-xserver/xserver-xf86-common.inc
> > index 000aea3..4c8b732 100644
> > --- a/meta/recipes-graphics/xorg-xserver/xserver-xf86-common.inc
> > +++ b/meta/recipes-graphics/xorg-xserver/xserver-xf86-common.inc
> > @@ -35,3 +35,8 @@ FILES_${PN}-dbg += "${libdir}/xorg/modules/.debug \
> >  SRC_URI += "file://macro_tweak.patch"
> >  
> >  EXTRA_OECONF = "--with-fop=no"
> > +
> > +PACKAGECONFIG ??= "udev"
> > +PACKAGECONFIG[hal] = "--enable-config-hal,--disable-config-hal,,hal"
> > +PACKAGECONFIG[udev] = "--enable-config-udev,--disable-config-udev,,udev"
> 
> This should probably be 
> +PACKAGECONFIG[hal] = "--enable-config-hal,--disable-config-hal,,hal"
> +PACKAGECONFIG[udev] = "--enable-config-udev,--disable-config-udev,udev,"
> 
> as we don't want udev in RDEPENDS (libudev is enough).

Does it need udev to build? I suspect you're right. I found it a little
odd it didn't seem to need hal as a build dependency.

> And can we apply this after my Xorg patchset? Because I don't want to
> rebase it for 4th time ;).

What I'm trying to avoid is introducing config options which we're not
going to use. Looking at the xserver patches in your xorg series, they
still do too many things in one patch so I think they're going to need
to be split down further. I'm reluctant to ask you to do it so I'm
poking around some of this area myself too...

Cheers,

Richard