From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Saul Wold <saul.wold@intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] eds: Update to work with glib-2.0
Date: Wed, 12 Oct 2011 23:29:40 +0100 [thread overview]
Message-ID: <1318458589.23801.195.camel@ted> (raw)
In-Reply-To: <4E96082C.3040803@intel.com>
On Wed, 2011-10-12 at 14:35 -0700, Saul Wold wrote:
> On 10/12/2011 06:39 AM, Richard Purdie wrote:
> > Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/meta/recipes-sato/eds/eds-dbus/depbuildfix.patch b/meta/recipes-sato/eds/eds-dbus/depbuildfix.patch
> > new file mode 100644
> > index 0000000..0785a93
> > --- a/dev/null
> > +++ b/meta/recipes-sato/eds/eds-dbus/depbuildfix.patch
> > @@ -0,0 +1,78 @@
> > +G_CONST_RETURN is deprecated in glib 2.30 so remove to to avoid
> > +build failures. Also resolve other deprecation issues.
> > +
> > +RP 2011/10/12
>
> Shouldn't this really be a "Signed-off-by" line?
The original intent with patches was to understand who wrote them. That
is extremely useful information in X years time and was missing in many
cases. The sign-off doesn't mean much in this context. The above does
identify who wrote it (and when) so I'm not convinced there is a problem
there. Admittedly I have not put my full name or email address so its
not as clear as it could be but I've been doing this for a while now and
I'm the only one signing patches with those initials...
Cheers,
Richard
prev parent reply other threads:[~2011-10-12 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 13:39 [PATCH] eds: Update to work with glib-2.0 Richard Purdie
2011-10-12 21:35 ` Saul Wold
2011-10-12 22:29 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318458589.23801.195.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=saul.wold@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox