Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] mesa-dri: Enable swrast only by default and intel drivers only on IA platform
Date: Fri, 14 Oct 2011 23:15:02 +0100	[thread overview]
Message-ID: <1318630511.2342.52.camel@ted> (raw)
In-Reply-To: <20111014160553.GM3542@jama.jama.net>

On Fri, 2011-10-14 at 18:05 +0200, Martin Jansa wrote:
> On Fri, Oct 14, 2011 at 04:55:50PM +0100, Richard Purdie wrote:
> > On Fri, 2011-10-14 at 17:30 +0200, Martin Jansa wrote:
> > > On Fri, Oct 14, 2011 at 04:25:16PM +0100, Richard Purdie wrote:
> > > > On Fri, 2011-10-14 at 11:46 -0300, Otavio Salvador wrote:
> > > > > +1
> > > > > 
> > > > > Just another thing, I'd prefer to have DRIDRIVERS as ?= so machine can
> > > > > override it.
> > > > 
> > > > I really wouldn't recommend overriding this on a per machine basis, it
> > > > needs to be on a per arch basis. This is because the recipe is not
> > > > machine specific (nor should it be).
> > > > 
> > > > Configuration therefore falls to the distro, not machine.
> > > 
> > > Why not make it machine specific only when machine provides own module
> > > (like the case with glamo on om-gta02)?
> > > 
> > > Or recipe cannot change PACKAGE_ARCH in some special cases (like
> > > $MACHINE in path to some file in SRC_URI) anymore?
> > 
> > It works just fine but its not nice practise in my opinion for a library
> > like this and I don't see there is any need in this case. Certainly I
> > don't see it as something OE-Core should be recommending.
> 
> So can I send patches adding my glamo.patch to libdrm and mesa-dri so we
> can add glamo to 
> DRIDRIVERS_armv4t ?

No, what I mean is if the layer containing that machine appends those
patches for arm in general (or armv4t), you can then enable the dri
drivers for armv4t in general to.

It means you would have to keep the layer enabled whenever generating
armv4t feeds but I think that is ok as long as you know about it?

Cheers,

Richard




  reply	other threads:[~2011-10-14 22:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-14 14:42 [PATCH] mesa-dri: Enable swrast only by default and intel drivers only on IA platform Richard Purdie
2011-10-14 14:46 ` Otavio Salvador
2011-10-14 15:25   ` Richard Purdie
2011-10-14 15:30     ` Martin Jansa
2011-10-14 15:40       ` Koen Kooi
2011-10-14 15:55       ` Richard Purdie
2011-10-14 16:05         ` Martin Jansa
2011-10-14 22:15           ` Richard Purdie [this message]
2011-10-14 22:53             ` Khem Raj
2011-10-14 23:17               ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318630511.2342.52.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox