Re: [PATCH 2/2] mesa-common: install internal GL headers to libgl-dev

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2011-10-15 at 15:27 +0100, Phil Blundell wrote:
> On Sat, 2011-10-15 at 11:54 +0200, Martin Jansa wrote:
> >  FILES_${PN}-dbg += "${libdir}/dri/.debug/*"
> >  FILES_libegl-dbg += "${libdir}/egl/.debug/*"
> > +
> > +do_install_append () {
> > +    install -d ${D}/${includedir}/GL
> > +    cp -pPr ${S}/include/GL/internal* ${D}/${includedir}/GL
> > +}
> 
> Why is this needed?  If the internal headers are meant to be installed,
> why doesn't "make install" do that?  Or, conversely, if they aren't
> intended to be installed, why do we want them there?
> 
> Please add some commentary to the checkin message explaining the
> rationale for the patch.

Ideally we should write a patch fixing the Makefile so dri-swrast
installs the pieces the xserver needs to build. Does it need both
sarea.h and dri_interface.h or just the latter?

FWIW the dri-i9* drivers install the dri header but not sarea.h.

Cheers,

Richard