Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [CONSOLIDATED PULL - v2 09/26] x86 tune files: set baselib for x32 tune as libx32
Date: Thu, 20 Oct 2011 13:44:09 +0100	[thread overview]
Message-ID: <1319114649.2410.8.camel@ted> (raw)
In-Reply-To: <1319101363.22985.259.camel@phil-desktop>

On Thu, 2011-10-20 at 10:02 +0100, Phil Blundell wrote:
> On Thu, 2011-10-20 at 00:50 -0700, Saul Wold wrote:
> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
> > 
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> Why is this a good thing?  There is no explanation in the commit
> message.

Agreed, we need to improve the commit messages. I've merged this one
with some additional comments but can people please keep good commit
messages in mind.

Cheers,

Richard




  reply	other threads:[~2011-10-20 12:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20  7:50 [CONSOLIDATED PULL - v2 00/26] More Updates and Fixes Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 01/26] poky: fix broken ubifs link in deploy folder Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 02/26] bluez4: Add glib-2.0 to DEPENDS Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 03/26] gcc-4.6: Upgrade SRCREV to latest FSF 4.6 branch Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 04/26] gcc-4.6: Backport PR46934 fix Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 05/26] ghostscript: Disable parallel make due to install issues Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 06/26] src_distribute.bbclass, src_distribute_local.bbclass: mostly rewritten Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 07/26] ghostscript: renamed x86_64 to x86-64 for patch to work Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 08/26] insane.bbclass: print full path on invalid LICENSE_FILES_CHKSUM Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 09/26] x86 tune files: set baselib for x32 tune as libx32 Saul Wold
2011-10-20  9:02   ` Phil Blundell
2011-10-20 12:44     ` Richard Purdie [this message]
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 10/26] python-scons: upgrade from 2.0.1 to 2.1.0 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 11/26] python-dbus: upgrade from 0.83.2 to 0.84.0 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 12/26] libxml-parser-perl: upgrade from 2.40 to 2.41 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 13/26] distro-tracking: update data for some toolchain recipes Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 14/26] ghostscript: update to 9.04 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 15/26] libxml-sax-perl: update to 0.99 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 16/26] liburi-perl: update to 1.59 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 17/26] libsdl: update to 1.2.14 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 18/26] distro_tracking_fields: update packages tracking fields Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 19/26] ccache: update to 3.1.6 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 20/26] chkconfig: Update to 1.3.55 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 21/26] module.bbclass: add lock to prevent error bulding ext modules Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 22/26] gst-plugins-good: update to 0.10.30 Saul Wold
2011-10-20  7:50 ` [CONSOLIDATED PULL - v2 23/26] tzdata: updated SRC_URI and update to 2011k Saul Wold
2011-10-20  7:51 ` [CONSOLIDATED PULL - v2 24/26] tzcode-native: update SRC_URI to new IANA location Saul Wold
2011-10-20  7:51 ` [CONSOLIDATED PULL - v2 25/26] gst-plugins-good: correctly handle gconf schema Saul Wold
2011-10-20  7:51 ` [CONSOLIDATED PULL - v2 26/26] distro-tracking-fields: update fields for tzdata and gst-plugins-good Saul Wold
2011-10-20 14:18 ` [CONSOLIDATED PULL - v2 00/26] More Updates and Fixes Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319114649.2410.8.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox