From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct location
Date: Wed, 26 Oct 2011 21:54:24 +0100 [thread overview]
Message-ID: <1319662464.12054.1.camel@ted> (raw)
In-Reply-To: <840A81C1B782724A8EB52725BD519EFF1A8959@MBX20.4emm.local>
On Fri, 2011-10-21 at 05:23 +0000, James Limbouris wrote:
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Khem Raj
> > Sent: Friday, 21 October 2011 1:16 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
> > location
> >
> > On Thu, Oct 20, 2011 at 10:12 PM, James Limbouris
> > <james@digitalmatter.com.au> wrote:
> > >> -----Original Message-----
> > >> From: openembedded-core-bounces@lists.openembedded.org
> > >> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of
> > >> Khem Raj
> > >> Sent: Friday, 21 October 2011 1:03 PM
> > >> To: openembedded-core@lists.openembedded.org
> > >> Subject: [OE-core] [PATCH 3/3] gcc-configure-sdk: Point sysroot to correct
> > >> location
> > >>
> > >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > >> ---
> > >> meta/recipes-devtools/gcc/gcc-configure-sdk.inc | 2 +-
> > >> 1 files changed, 1 insertions(+), 1 deletions(-)
> > >>
> > >> diff --git a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc b/meta/recipes-
> > >> devtools/gcc/gcc-configure-sdk.inc
> > >> index de80870..98fd4c1 100644
> > >> --- a/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> > >> +++ b/meta/recipes-devtools/gcc/gcc-configure-sdk.inc
> > >> @@ -7,7 +7,7 @@ USE_NLS = '${@base_conditional( "TARGET_OS", "linux-
> > >> uclibceabi", "no", "", d )}'
> > >> EXTRA_OECONF_PATHS = "--with-local-
> > >> prefix=${SDKPATH}/sysroots/${TARGET_SYS}${target_exec_prefix} \
> > >> --with-gxx-include-dir=${target_includedir}/c++ \
> > >> --with-build-time-
> > >> tools=${STAGING_DIR_NATIVE}${prefix_native}/${TARGET_SYS}/bin \
> > >> - --with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS} \
> > >> + --with-
> > >> sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-
> > >> ${TARGET_OS} \
> > >> --with-build-sysroot=${STAGING_DIR_TARGET}"
> > >>
> > >> #
> > >> --
> > >> 1.7.5.4
> > >>
> > >
> > > Shouldn't --with-local-prefix be changed too? I am testing with both
> > ${TARGET_SYS}'s replaced. Will post results shortly.
> >
> > yes I think both places it should change
> >
>
> Ok, I've tested with both changed, and the corresponding binutils patch, and both Qt and kernel compiles are working.
I took these patches but I would like to stress that we shouldn't need
to rely on the hardcoded path in the compiler, it should be picking up
any alternative sysroot paths from the environment. If this isn't
happening, we should be figuring out why not. This change therefore
hides issues and does not fix the problem entirely :(.
Cheers,
Richard
next prev parent reply other threads:[~2011-10-26 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 5:02 [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Khem Raj
2011-10-21 5:02 ` [PATCH 2/3] binutils-cross-canadian: Point sysroot to correct location Khem Raj
2011-10-21 5:02 ` [PATCH 3/3] gcc-configure-sdk: " Khem Raj
2011-10-21 5:12 ` James Limbouris
2011-10-21 5:16 ` Khem Raj
2011-10-21 5:23 ` James Limbouris
2011-10-26 20:54 ` Richard Purdie [this message]
2011-10-27 3:52 ` James Limbouris
2011-10-27 4:11 ` Tom Rini
2011-10-26 20:19 ` [PATCH 1/3] tcmode-default.inc: Add TRANSLATED_TARGET_ARCH suffix to binutils-cross-canadian Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319662464.12054.1.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox