Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: McClintock Matthew-B29882 <B29882@freescale.com>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 1/2] Add new strace-graph package to avoid making perl a dependecy for all of strace
Date: Fri, 28 Oct 2011 16:54:47 +0100	[thread overview]
Message-ID: <1319817308.22985.448.camel@phil-desktop> (raw)
In-Reply-To: <CAEsOVNdwf8xYTp0K1JftUcMfmuuzMbMKahrP56Q1wx5yf4VPBw@mail.gmail.com>

On Fri, 2011-10-28 at 15:34 +0000, McClintock Matthew-B29882 wrote:
> On Fri, Oct 28, 2011 at 3:55 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >> -RDEPENDS = "perl"
> >> +PACKAGES_prepend = "${PN}-graph "
> >> +FILES_${PN}-graph = "${bindir}/strace-graph"
> >> +RDEPENDS_${PN}-graph = "perl"
> >
> > I should have been clearer in my original email, pretty much every other
> > recipe uses += or =+ in this context. Whilst the _prepend override is
> > probably ok, its probably a bit heavy in this case and the standard
> > operator should work just fine.
> 
> usr/bin/strace-graph will be picked up by the default rules for ${PN}
> - by prepending I thought I was letting strace-graph get picked out
> first in ${PN}-graph then everything else could go in ${PN} without
> having the explicitly list a new rule for ${PN}.

That logic sounds reasonable, but I think Richard's point was that it's
more conventional to use "=+" rather than an override for prepending.

p.





  reply	other threads:[~2011-10-28 16:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-27  5:14 [PATCH 1/2] Add new strace-graph package to avoid making perl a dependecy for all of strace Matthew McClintock
2011-10-27  5:14 ` [PATCH 2/2] Add new util-linux-chkdupexe package to avoid making perl a dependecy for all of util-linux Matthew McClintock
2011-10-27  7:32   ` Richard Purdie
2011-10-27  7:26 ` [PATCH 1/2] Add new strace-graph package to avoid making perl a dependecy for all of strace Richard Purdie
2011-10-27 19:31   ` [PATCH v2 " Matthew McClintock
2011-10-28  8:55     ` Richard Purdie
2011-10-28 15:34       ` McClintock Matthew-B29882
2011-10-28 15:54         ` Phil Blundell [this message]
2011-10-28 20:07           ` McClintock Matthew-B29882
2011-10-31  9:05             ` Paul Eggleton
2011-10-31 16:26               ` [PATCH v3 " Matthew McClintock
2011-11-02  0:35                 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319817308.22985.448.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=B29882@freescale.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox