From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RNmUk-0005mM-MB for openembedded-core@lists.openembedded.org; Tue, 08 Nov 2011 15:17:46 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id pA8EBULF032634; Tue, 8 Nov 2011 14:11:30 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 31928-08; Tue, 8 Nov 2011 14:11:26 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id pA8EBLbB032628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 8 Nov 2011 14:11:21 GMT Message-ID: <1320761482.10843.38.camel@ted> From: Richard Purdie To: Patches and discussions about the oe-core layer Date: Tue, 08 Nov 2011 14:11:22 +0000 In-Reply-To: <1320741708-15019-1-git-send-email-eric@eukrea.com> References: <4EB86E07.5020907@intel.com> <1320741708-15019-1-git-send-email-eric@eukrea.com> X-Mailer: Evolution 3.2.1- Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net X-MIME-Autoconverted: from 8bit to quoted-printable by tim.rpsys.net id pA8EBULF032634 Cc: Scott Garman Subject: Re: [PATCH 1/2] useradd.bbclass: handle nativesdk case X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2011 14:17:46 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2011-11-08 at 09:41 +0100, Eric B=C3=A9nard wrote: > * without this patch, building dbus-nativesdk leads to a missing > dependency on 'base-passwd-nativesdk' > This was added by commit 46e6c3fa8034b12d178d605f3f5d7efe69671a13 > * this patch handle the nativesdk case in the class useradd > * close bug 1702 http://bugzilla.pokylinux.org/show_bug.cgi?id=3D1702 > * v2 from Scott Garman with Richard Purdie's tricks >=20 > Signed-off-by: Eric B=C3=A9nard > Signed-off-by: Scott Garman > --- > meta/classes/useradd.bbclass | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclas= s > index 0f9b84c..6c933e1 100644 > --- a/meta/classes/useradd.bbclass > +++ b/meta/classes/useradd.bbclass > @@ -3,7 +3,9 @@ USERADDPN ?=3D "${PN}" > # base-passwd-cross provides the default passwd and group files in the > # target sysroot, and shadow -native and -sysroot provide the utilitie= s > # and support files needed to add and modify user and group accounts > -DEPENDS_append =3D " base-passwd shadow-native shadow-sysroot" > +DEPENDS_append =3D "${USERADDDEPENDS}" > +USERADDDEPENDS =3D " base-passwd shadow-native shadow-sysroot" > +USERADDDEPENDS_virtclass-nativesdk =3D "" > =20 > # This preinstall function will be run in two contexts: once for the > # native sysroot (as invoked by the useradd_sysroot() wrapper), and > @@ -95,8 +97,9 @@ useradd_sysroot_sstate () { > fi > } > =20 > -do_install[prefuncs] +=3D "useradd_sysroot" > -SSTATEPOSTINSTFUNCS +=3D "useradd_sysroot_sstate" > +do_install[prefuncs] +=3D "${SYSROOTFUNC}" > +SYSROOTFUNC =3D "useradd_sysroot" > +SYSROOTFUNC_virtclass-nativesdk =3D "" Nearly but you're missing a: SSTATEPOSTINSTFUNCS +=3D "${SYSROOTPOSTFUNC}" SYSROOTPOSTFUNC =3D "useradd_sysroot_sstate" SYSROOTPOSTFUNC_virtclass-nativesdk =3D "" Cheers, Richard