Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] multilib: Drop MULTILIB_IMAGE_INSTALL
Date: Tue, 08 Nov 2011 14:29:35 +0000	[thread overview]
Message-ID: <1320762575.10843.45.camel@ted> (raw)
In-Reply-To: <8d5fb3fc99567457b497c859f333fe68b49806cb.1320732950.git.dongxiao.xu@intel.com>

On Tue, 2011-11-08 at 14:19 +0800, Dongxiao Xu wrote:
> There should just be a single IMAGE_INSTALL variable. If the package
> backends need this split into different multilib components they should
> be responsible for doing this, not the user.
> 
> This commit removes the MULTILIB_IMAGE_INSTALL variable.
> 
> [YOCTO #1564]
> 
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
>  meta/classes/image.bbclass       |    4 +---
>  meta/classes/multilib.bbclass    |    5 ++---
>  meta/classes/package_ipk.bbclass |   31 ++++++++++++++++++++++++++++---
>  meta/classes/package_rpm.bbclass |   37 +++++++++----------------------------
>  meta/classes/rootfs_ipk.bbclass  |    3 +--
>  meta/classes/rootfs_rpm.bbclass  |    3 +--
>  6 files changed, 42 insertions(+), 41 deletions(-)

I'll take this as its a definite improvement over the current situation.
I did however wonder what happens if we try something tri-arch e.g.
i586, x86_64 and x32?

I get the feeling both package backends could really use some cleanup
now we have the basics working and better abstraction of the code so we
can loop over something like tri-arch (or more) easily...

Cheers,

Richard




  reply	other threads:[~2011-11-08 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08  6:19 [PATCH 0/1][PULL] multilib: drop MULTILIB_IMAGE_INSTALL variable Dongxiao Xu
2011-11-08  6:19 ` [PATCH 1/1] multilib: Drop MULTILIB_IMAGE_INSTALL Dongxiao Xu
2011-11-08 14:29   ` Richard Purdie [this message]
2011-11-09  1:25     ` Xu, Dongxiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320762575.10843.45.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox