From: Phil Blundell <philb@gnu.org>
To: oe-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH] libnss-mdns: avoid race condition in postinst
Date: Mon, 14 Nov 2011 13:06:51 +0000 [thread overview]
Message-ID: <1321276012.29435.24.camel@phil-desktop> (raw)
Writing to "/tmp/nsswitch.conf" leads to a race condition if two
copies of the postinst are running simultaneously. Fix this by
modifying /etc/nsswitch.conf in place using sed -i. Also make the
same change to the prerm for consistency although the race will not
occur here in practice.
Signed-off-by: Phil Blundell <philb@gnu.org>
---
.../libnss-mdns/libnss-mdns_0.10.bb | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/meta/recipes-connectivity/libnss-mdns/libnss-mdns_0.10.bb b/meta/recipes-connectivity/libnss-mdns/libnss-mdns_0.10.bb
index 5f614f8..8770714 100644
--- a/meta/recipes-connectivity/libnss-mdns/libnss-mdns_0.10.bb
+++ b/meta/recipes-connectivity/libnss-mdns/libnss-mdns_0.10.bb
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=2d5025d4aa3495befef8f17206a5b0a1"
DEPENDS = "avahi"
RDEPENDS_${PN} = "avahi-daemon"
-PR = "r3"
+PR = "r4"
SRC_URI = "http://0pointer.de/lennart/projects/nss-mdns/nss-mdns-${PV}.tar.gz"
@@ -26,14 +26,12 @@ EXTRA_OECONF = "--libdir=${base_libdir} --disable-lynx --enable-avahi"
# TODO: pattern based configuration update
pkg_postinst_${PN} () {
cat $D/etc/nsswitch.conf | grep "hosts:\s*files dns$" > /dev/null && {
- cat $D/etc/nsswitch.conf | sed 's/hosts:\s*files dns/& mdns4/' > /tmp/nsswitch.conf
- mv /tmp/nsswitch.conf $D/etc/nsswitch.conf
+ sed -i 's/hosts:\s*files dns/& mdns4/' $D/etc/nsswitch.conf
}
}
pkg_prerm_${PN} () {
cat /etc/nsswitch.conf | grep "hosts:\s*files dns mdns4$" > /dev/null && {
- cat /etc/nsswitch.conf | sed 's/\(hosts:\s*files dns\) mdns4*/\1/' > /tmp/nsswitch.conf
- mv /tmp/nsswitch.conf /etc/nsswitch.conf
+ sed -i 's/\(hosts:\s*files dns\) mdns4*/\1/' /etc/nsswitch.conf
}
}
--
1.7.4.1
next reply other threads:[~2011-11-14 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 13:06 Phil Blundell [this message]
2011-11-15 12:21 ` [PATCH] libnss-mdns: avoid race condition in postinst Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321276012.29435.24.camel@phil-desktop \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox