Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] base-passwd: Fix the broken preinst/postinstall
Date: Mon, 14 Nov 2011 13:58:33 +0000	[thread overview]
Message-ID: <1321279113.26881.63.camel@ted> (raw)
In-Reply-To: <8AFC2447-9963-4DF0-80E2-198516B3A813@dominion.thruhere.net>

On Mon, 2011-11-14 at 14:37 +0100, Koen Kooi wrote:
> Op 14 nov. 2011, om 13:52 heeft Phil Blundell het volgende geschreven:
> 
> > On Mon, 2011-11-14 at 12:49 +0000, Richard Purdie wrote:
> >> The preinst accesses file which may not yet have been unpacked.
> >> The postinst is too late for the creation of these files
> >> for at least the opkg backend.
> >> 
> >> This patch therefore encodes the file contents into the preinst,
> >> resolving the various issues once and for all.
> >> 
> >> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > 
> > If you're going to do that (which does look reasonable) then you might
> > as well stop the package from shipping passwd.master and group.master at
> > all.  I don't think anything else uses those files so they're just
> > wasting space at the moment.
> 
> IIRC 'update-passwd' will use those. That's not a criticism on Phils
> suggestion, I like it very much.

I've posted a second patch which moves these pieces into a separate
package and actually uses update-passwd.

Cheers,

Richard





      parent reply	other threads:[~2011-11-14 14:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 12:49 [PATCH] base-passwd: Fix the broken preinst/postinstall Richard Purdie
2011-11-14 12:52 ` Phil Blundell
2011-11-14 13:03   ` Otavio Salvador
2011-11-14 13:37   ` Koen Kooi
2011-11-14 13:57     ` [PATCH] base-passwd: Move update-passwd into a separate package Richard Purdie
2011-11-14 15:15       ` Phil Blundell
2011-11-14 17:19         ` Richard Purdie
2011-11-14 17:38           ` Phil Blundell
2011-11-14 13:58     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321279113.26881.63.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox