Re: [PATCH] libtool-cross: Upbreak and actually use more of it

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2011-11-17 at 10:08 +0100, Paul Menzel wrote:
> Dear Richard,
> Am Donnerstag, den 17.11.2011, 00:13 +0000 schrieb Richard Purdie:
> 
> unfortunately I could not find the meaning of upbreak here.

Sorry, its a typo and should be "unbreak"

> 
> > We should be using libtool-cross for cross compiling but
> > were not.
> 
> Is that just a cosmetic thing or did packages break?

Its currently harmless but when I applied my other libtool changes,
things did break.

> > This patch sets datadir so libtoolize ends up
> > containing correct paths. It then installs libtoolize.
> > 
> > The path ltmain.sh was installed to was incorrect and this is fixed.
> > 
> > We also now install all the libtool m4 macros.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/meta/recipes-devtools/libtool/libtool-cross_2.4.bb b/meta/recipes-devtools/libtool/libtool-cross_2.4.bb
> > index 596528a..4e6e3f2 100644
> > --- a/meta/recipes-devtools/libtool/libtool-cross_2.4.bb
> > +++ b/meta/recipes-devtools/libtool/libtool-cross_2.4.bb
> > @@ -1,10 +1,13 @@
> >  require libtool-${PV}.inc
> >  
> > -PR = "r5"
> > +PR = "r7"
> 
> Increase just by one?

Ideally I guess, yes.

> >  PACKAGES = ""
> >  SRC_URI += "file://prefix.patch"
> >  SRC_URI += "file://fixinstall.patch"
> >  
> > +target_datadir := "${datadir}"
> 
> Is not already defined this way in `bitbake.conf`?
> 
> $ git grep target_d ./meta/conf/bitbake.conf
> meta/conf/bitbake.conf:target_datadir := "${datadir}"

Good catch, I'd forgotten we'd saved this already.

> > +datadir = "${STAGING_DIR_TARGET}${target_datad

Cheers,

Richard