From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] shared-mime-info: fix ordering of PACKAGES
Date: Fri, 18 Nov 2011 14:34:47 +0000 [thread overview]
Message-ID: <1321626887.16309.2.camel@ted> (raw)
In-Reply-To: <CACW_hTYXNDBFWtxOK86fz5P55Va700rQYWpO6thrUH9OQsA+8Q@mail.gmail.com>
On Fri, 2011-11-18 at 15:28 +0100, Frans Meulenbroeks wrote:
>
>
> 2011/11/18 Koen Kooi <koen@dominion.thruhere.net>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> .../shared-mime-info/shared-mime-info.inc | 2 +-
> .../shared-mime-info/shared-mime-info_0.91.bb | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> index 57e829c..d7fa67c 100644
> ---
> a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> +++
> b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
> @@ -19,7 +19,7 @@ FILES_${PN}-dev +=
> "${datadir}/pkgconfig/shared-mime-info.pc"
>
> # freedesktop.org.xml is only required when updating the mime
> database,
> # package it separately
> -PACKAGES += "shared-mime-info-data"
> +PACKAGES =+ "shared-mime-info-data"
> FILES_shared-mime-info-data =
> "${datadir}/mime/packages/freedesktop.org.xml"
> RDEPENDS_shared-mime-info-data = "shared-mime-info"
>
> diff --git
> a/meta/recipes-support/shared-mime-info/shared-mime-info_0.91.bb b/meta/recipes-support/shared-mime-info/shared-mime-info_0.91.bb
> index bc4a8f7..7ae6e10 100644
> ---
> a/meta/recipes-support/shared-mime-info/shared-mime-info_0.91.bb
> +++
> b/meta/recipes-support/shared-mime-info/shared-mime-info_0.91.bb
> @@ -1,5 +1,5 @@
> require shared-mime-info.inc
> -PR = "r2"
> +PR = "r3"
>
> SRC_URI[md5sum] = "982a211560ba4c47dc791ccff34e8fbc"
> SRC_URI[sha256sum] =
> "98cfebe1d809afb24934e634373821e2a1dfa86fc6462cab230589a1c80988bd"
> --
> 1.7.2.5
>
> For my education:
> Is ordering of PACKAGES relevant? If so, please enlighten me why. If
> not why this patch?
Just to cut the story short here, I agree the commit message could have
had more information. There are bug reports on the list related to this
and its clear there is a problem.
I've therefore taken the patch since I'd rather fix this than let more
people fall over the problem over the weekend. In other circumstances I
might have held out for more of a commit message.
Cheers,
Richard
prev parent reply other threads:[~2011-11-18 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 14:13 [PATCH] shared-mime-info: fix ordering of PACKAGES Koen Kooi
2011-11-18 14:27 ` Richard Purdie
2011-11-18 14:28 ` Frans Meulenbroeks
2011-11-18 14:34 ` Paul Eggleton
2011-11-19 15:02 ` Frans Meulenbroeks
2011-11-19 15:13 ` Martin Jansa
2011-11-20 13:11 ` Frans Meulenbroeks
2011-11-18 14:34 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321626887.16309.2.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox