Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/3] gmp: also generate the libgmpcxx library
Date: Wed, 23 Nov 2011 10:12:58 +0000	[thread overview]
Message-ID: <1322043179.29435.307.camel@phil-desktop> (raw)
In-Reply-To: <4d677dc2f3f0ea0448298b513735e123a1ed6535.1322027494.git.nitin.a.kamble@intel.com>

On Tue, 2011-11-22 at 21:55 -0800, nitin.a.kamble@intel.com wrote:
> diff --git a/meta/recipes-support/gmp/gmp.inc b/meta/recipes-support/gmp/gmp.inc
> index 66349e6..10c3b9d 100644
> --- a/meta/recipes-support/gmp/gmp.inc
> +++ b/meta/recipes-support/gmp/gmp.inc
> @@ -14,3 +14,7 @@ ARM_INSTRUCTION_SET = "arm"
>  acpaths = ""
>  
>  BBCLASSEXTEND = "native nativesdk"
> +
> +EXTRA_OECONF += " --enable-cxx=detect"
> +
> +LEAD_SONAME = "libgmp.so"

I think it would be better to put the C++ libraries in a separate
package, otherwise you will waste on-target space for the people who
don't need them (which, presumably, is everyone who was using gmp prior
to your patch).  LEAD_SONAME is almost never a good thing to use.

p.





  reply	other threads:[~2011-11-23 10:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23  5:55 [PATCH 0/3] Various Fixes nitin.a.kamble
2011-11-23  5:55 ` [PATCH 1/3] gmp: also generate the libgmpcxx library nitin.a.kamble
2011-11-23 10:12   ` Phil Blundell [this message]
2011-11-23  5:55 ` [PATCH 2/3] at: update the upstream-status of patches nitin.a.kamble
2011-11-23  5:55 ` [PATCH 3/3] site/x86_64-linux: add cvs config variables nitin.a.kamble
2011-11-24 22:47 ` [PATCH 0/3] Various Fixes Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322043179.29435.307.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox