From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RTC5A-0008Hs-NH for openembedded-core@lists.openembedded.org; Wed, 23 Nov 2011 13:37:44 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id pANCVCtr011744 for ; Wed, 23 Nov 2011 12:31:13 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 32683-06 for ; Wed, 23 Nov 2011 12:31:04 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id pANCUvxN011699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 23 Nov 2011 12:30:59 GMT Message-ID: <1322051464.18926.76.camel@ted> From: Richard Purdie To: Patches and discussions about the oe-core layer Date: Wed, 23 Nov 2011 12:31:04 +0000 In-Reply-To: References: <1321979300.18926.58.camel@ted> X-Mailer: Evolution 3.2.1- Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Subject: Re: [PATCH 1/5] matchbox-stroke: Fix linking error with gold X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2011 12:37:44 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2011-11-22 at 19:00 -0800, Khem Raj wrote: > On Tue, Nov 22, 2011 at 8:28 AM, Richard Purdie > wrote: > > On Sun, 2011-11-20 at 09:50 -0800, Khem Raj wrote: > >> Gold defaults to no-add-needed thetefore > >> it does not link with librtaries that are not on cmdline > >> it needs libXrender but is not on the linker cmdline > >> so add it. > >> > >> Signed-off-by: Khem Raj > >> --- > >> .../matchbox-stroke/files/ldadd_libXrender.patch | 25 ++++++++++++++++++++ > >> .../matchbox-stroke/matchbox-stroke_git.bb | 6 +++- > >> 2 files changed, 29 insertions(+), 2 deletions(-) > >> create mode 100644 meta/recipes-sato/matchbox-stroke/files/ldadd_libXrender.patch > >> > >> diff --git a/meta/recipes-sato/matchbox-stroke/files/ldadd_libXrender.patch b/meta/recipes-sato/matchbox-stroke/files/ldadd_libXrender.patch > >> new file mode 100644 > >> index 0000000..90d2057 > >> --- /dev/null > >> +++ b/meta/recipes-sato/matchbox-stroke/files/ldadd_libXrender.patch > >> @@ -0,0 +1,25 @@ > >> +with GNU binutils-gold the > >> +important difference is that --no-add-needed is the default behavior of GNU > >> +binutils-gold. Please provide all needed libraries to the linker when building > >> +your executables. > >> + > >> +Otherwise we get link errors like > >> + > >> +/home/kraj/work/angstrom/build/tmp-angstrom_2010_x-eglibc/sysroots/x86_64-linux/usr/libexec/armv5te-angstrom-linux-gnueabi/gcc/arm-angstrom-linux-gnueabi/4.6.2/ld: matchbox-stroke-ui.o: in function mb_stroke_ui_resources_create:matchbox-stroke-ui.c:223: error: undefined reference to 'XRenderCreatePicture'collect2: ld returned 1 exit statusmake[2]: *** [matchbox-stroke] Error 1 > >> + > >> +Signed-off-by: Khem Raj > >> + > >> +Upstream-Status: Pending > >> +Index: git/src/Makefile.am > >> +=================================================================== > >> +--- git.orig/src/Makefile.am 2011-10-22 19:25:52.000000000 -0700 > >> ++++ git/src/Makefile.am 2011-10-22 19:27:07.746428946 -0700 > >> +@@ -6,7 +6,7 @@ > >> + > >> + bin_PROGRAMS = matchbox-stroke > >> + > >> +-matchbox_stroke_LDADD = $(MBSTROKE_LIBS) $(EXPAT_LIBS) -lm > >> ++matchbox_stroke_LDADD = $(MBSTROKE_LIBS) $(EXPAT_LIBS) -lm -lXrender > >> + > > > > I had a look at this and -lXrender is listed in MBSTROKE_LIBS. I'm > > therefore a little puzzled on why this patch is needed? I appreciate the > > commandline is order sensitive but that order should work? > > In my case > > Makefile:MBSTROKE_LIBS = -lXft -lX11 -lXtst -lfakekey I can now see why I'm confused: http://git.yoctoproject.org/cgit.cgi/matchbox-stroke/commit/?id=2b772583b61d2f6e8358e7c80e10293fc27cfcb7 We need to update the SRCREV. I'll push something to take care of this. Cheers, Richard