From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237]
	helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72)
	(envelope-from <richard.purdie@linuxfoundation.org>)
	id 1RTcAU-0002lZ-Kb for openembedded-core@lists.openembedded.org;
	Thu, 24 Nov 2011 17:29:10 +0100
Received: from localhost (localhost [127.0.0.1])
	by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id pAOGMJUi026892;
	Thu, 24 Nov 2011 16:22:19 GMT
Received: from tim.rpsys.net ([127.0.0.1])
	by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new,
	port 10024) with LMTP
	id 26605-03; Thu, 24 Nov 2011 16:22:15 +0000 (GMT)
Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0)
	by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id pAOGMBui026885
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 24 Nov 2011 16:22:12 GMT
Message-ID: <1322151739.10928.3.camel@ted>
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Darren Hart <dvhart@linux.intel.com>
Date: Thu, 24 Nov 2011 16:22:19 +0000
In-Reply-To: <4ECE6D2C.1000704@linux.intel.com>
References: <1322146689.10818.1.camel@ted> <4ECE6D2C.1000704@linux.intel.com>
X-Mailer: Evolution 3.2.1- 
Mime-Version: 1.0
X-Virus-Scanned: amavisd-new at rpsys.net
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bitbake.conf: Set BB_CONSOLELOG so we log console messages by default
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.11
Precedence: list
Reply-To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.linuxtogo.org/pipermail/openembedded-core>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Nov 2011 16:29:10 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Thu, 2011-11-24 at 08:13 -0800, Darren Hart wrote:
> I believe this is the fix for Yocto Bug 1771? If so, awesome! A one
> liner, something to be said for really knowing the codebase.

It has a dependent on a ~5 line change to bitbake over on bitbake-devel
but yes, it fixes 1771.

> I would only suggest a commit log which includes the bug line,
> motivation and the approach taken, per the contribution guidelines.
> Maybe something like:
> 
> """""
> Fixes [YOCTO #1771]
> 
> The console log is often helpful for debugging issues. Difficult to
> reproduce bugs would benefit from a log being generated by default as it
> may be difficult to come by after the fact. Log to
> tmp/cooker.log.${DATETIME} by default.
> """""

FWIW most of the commit message is over on bitbake-devel but I should
have referenced the bug number, yes.

Cheers,

Richard