From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/4] runqemu: look for *image* to be more flexible for image names
Date: Thu, 24 Nov 2011 21:50:46 +0000 [thread overview]
Message-ID: <1322171446.10928.16.camel@ted> (raw)
In-Reply-To: <1a0942490d103eab0a5041806613ae16b963ae1b.1322128489.git.dexuan.cui@intel.com>
On Thu, 2011-11-24 at 18:08 +0800, Dexuan Cui wrote:
> From: Saul Wold <sgw@linux.intel.com>
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> scripts/runqemu | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 31e9822..a9a362f 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -114,7 +114,7 @@ while [ $i -le $# ]; do
> usage
> fi
> ;;
> - *-image-*)
> + *image*)
> if [ -z "$ROOTFS" ]; then
> if [ -f "$arg" ]; then
> process_filename $arg
As I mentioned to Saul, this is a bad idea since its very close to
matching things like bzImage. I seem to remember something with a
*image* name being in deploy before and having problems with that.
Cheers,
Richard
next prev parent reply other threads:[~2011-11-24 21:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 10:08 [PATCH 0/4] self-hosted-image: the first set of patch Dexuan Cui
2011-11-24 10:08 ` [PATCH 1/4] runqemu: look for *image* to be more flexible for image names Dexuan Cui
2011-11-24 21:50 ` Richard Purdie [this message]
2011-11-24 10:08 ` [PATCH 2/4] gcc-package-target.inc: add the symbol link /lib/cpp Dexuan Cui
2011-11-24 11:21 ` Richard Purdie
2011-11-24 15:37 ` Cui, Dexuan
2011-11-24 16:23 ` Richard Purdie
2011-11-24 23:09 ` Cui, Dexuan
2011-11-24 23:34 ` Richard Purdie
2011-11-24 10:08 ` [PATCH 3/4] Self Hosted Image: Added Task and Images Dexuan Cui
2011-11-24 10:08 ` [PATCH 4/4] coreutils: build and install hostname Dexuan Cui
2011-11-29 8:15 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322171446.10928.16.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox