Re: [PATCH 1/1] xserver-xorg: do not disable-dga as VESA driver requires it

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2011-11-22 at 15:24 -0200, Otavio Salvador wrote:
> On Tue, Nov 22, 2011 at 15:14, Phil Blundell <philb@gnu.org> wrote:
>         On Tue, 2011-11-22 at 13:47 +0000, Otavio Salvador wrote:
>         > Xorg VESA driver calls DGAInit enforcing this symbol to be
>         available
>         > to the driver to work.
>
>         Maybe it would be better to patch vesa.c to not require this
>         symbol
>         rather than forcing it on in the server for everyone.  Or
>         alternatively,
>         if you genuinely want DGA, maybe make it a PACKAGECONFIG
>         option.
>
> What worries me is that this changed lately as it were working fine.
>
> When xserver-xorg were update to 1.11 this has changed behind the
> scenes. This used to be disabled on lite flavour only.

Looking at vesa.c, there is quite a chunk of code in there depending on
DGA.

Is there any harm to building DGA apart from an extra package? Its a
self contained module isn't it?

If so, we should just be able to turn it on, package it separately and
forget about it?

Of course the ideal solution would be for someone to convert the vesa
driver to use the xrandr API...

Cheers,

Richard