Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] ghostscript-native: Ensure the sys/time/h fix is applied for native builds
Date: Sun, 27 Nov 2011 11:38:18 +0000	[thread overview]
Message-ID: <1322393898.4798.14.camel@ted> (raw)
In-Reply-To: <CAMKF1sr93K9y0=eLh_TFdhXai3FyV1aG44JGx625=EV1F_2oxg@mail.gmail.com>

On Sat, 2011-11-26 at 13:50 -0800, Khem Raj wrote:
> On Sat, Nov 26, 2011 at 2:16 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2011-11-25 at 18:39 -0800, Khem Raj wrote:
> >> On Fri, Nov 25, 2011 at 7:06 AM, Richard Purdie
> >> <richard.purdie@linuxfoundation.org> wrote:
> >> > On my system, the sys/time.h header is in a subdir off /usr/include
> >> > which causes a build failure. Apply the target CFLAGS fix to native
> >> > builds as well to address this.
> >>
> >> hmmm I thought CFLAGS would be automtically translated with
> >> BBCLASSEXTEND = "native"
> >
> > For native recipes, CFLAGS is replaced by BUILD_CFLAGS...
> 
> yes I see. A little niggle I was thinking of is that at present for a
> target recipe if something gets changed in CFLAGS or TARGET_CFLAGS
> that makes to the compile phase as combined CFLAGS
> 
> for native we rewrite CFLAGS = BUILD_CFLAGS
> 
> So either CFLAGS += BUILD_FLAGS for native CFLAGS += TARGET_CFLAGS
> will make it consistent or just override CFLAGS with BUILD_CFLAGS or
> TARGET_CFLAGS depending on recipe type

We could do with looking into addressing this inconsistency, yes.

Cheers,

Richard




      reply	other threads:[~2011-11-27 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-25 15:06 [PATCH] ghostscript-native: Ensure the sys/time/h fix is applied for native builds Richard Purdie
2011-11-26  2:39 ` Khem Raj
2011-11-26 10:16   ` Richard Purdie
2011-11-26 21:50     ` Khem Raj
2011-11-27 11:38       ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322393898.4798.14.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox