From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] qt4: fix sed to have correct *.pc files
Date: Tue, 29 Nov 2011 13:48:34 +0000 [thread overview]
Message-ID: <1322574514.6171.2.camel@ted> (raw)
In-Reply-To: <1322563625-22780-1-git-send-email-eric@eukrea.com>
On Tue, 2011-11-29 at 11:47 +0100, Eric Bénard wrote:
> it seems sed doesn't handle \? properly if the string in not between
> quotes.
>
> without this patch, we get something like (for example for QtDBusE.pc :
> Libs: -L${libdir} -lQtDBusE
> Libs.private: -L/home/ebenard/WORK/setup-scripts/build/tmp-angstrom_2010_x-eglibc/sysroots/board/
> usr/lib -L/usr/lib -L/home/ebenard/WORK/setup-scripts/build/tmp-angstrom_2010_x-eglibc/sysroots/board
> /usr/lib -lQtXmlE -L/usr/lib -lQtCoreE -lpthread
> Cflags: -DQT_SHARED -I/usr/include/qtopia -I${includedir}
>
> with the patch we get what is expected :
> Libs: -L${libdir} -lQtDBusE
> Libs.private: -lQtXmlE -lQtCoreE -lpthread
> Cflags: -DQT_SHARED -I/usr/include/qtopia -I${includedir}
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> meta/recipes-qt/qt4/qt4-embedded.inc | 2 +-
> meta/recipes-qt/qt4/qt4-x11-free.inc | 2 +-
> meta/recipes-qt/qt4/qt4.inc | 10 +++++-----
> 3 files changed, 7 insertions(+), 7 deletions(-)
Merged to master, thanks.
Richard
prev parent reply other threads:[~2011-11-29 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 10:47 [PATCH] qt4: fix sed to have correct *.pc files Eric Bénard
2011-11-29 10:52 ` Otavio Salvador
2011-11-29 13:48 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322574514.6171.2.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox