Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] classes: Apply libc-${LIBC} overrides to target recipes only
Date: Wed, 30 Nov 2011 23:26:08 +0000	[thread overview]
Message-ID: <1322695568.17484.82.camel@ted> (raw)
In-Reply-To: <1322606818-2817-1-git-send-email-raj.khem@gmail.com>

On Tue, 2011-11-29 at 14:46 -0800, Khem Raj wrote:
> Currently these overrides are enabled for native and nativesdk
> recipes as well when inheriting native and nativesdk classes. This patch
> filters these from OVERRIDES variables for native and nativesdk
> recipes.
> 
> oe_filter_out and oe_filter functions currently only operated on
> space separated strings. Since OVERRIDES are separated using ':'
> these functions are enhanced to take and additional parameter
> called 'sep' which defaults to None if not specified which means we keep
> the existing behaviour.
> 
> Drop the last parameter 'd' from filter functions since it was not being
> used.

This last piece worries me a lot. It requires a flag day where everyone
changes, particularly layers. I don't think that is something that is
acceptable.

I'd like to think simpler. How about we change tclibc*.inc to do
something like:

LIBCOVERRIDE = ":libc-glibc"
OVERRIDES .= "${LIBCOVERRIDE}"

and then native.bbclass can just do:

LIBCOVERRIDE = ""

Cheers,

Richard




  reply	other threads:[~2011-11-30 23:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 22:46 [PATCH] classes: Apply libc-${LIBC} overrides to target recipes only Khem Raj
2011-11-30 23:26 ` Richard Purdie [this message]
2011-11-30 23:33   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322695568.17484.82.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox