From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] zlib 1.2.5: install pkgconfig file, needed for e.g. modern webkit
Date: Thu, 01 Dec 2011 15:45:51 +0000 [thread overview]
Message-ID: <1322754351.17484.138.camel@ted> (raw)
In-Reply-To: <EA746CBB-C2AC-4DD2-83AB-880B4E2F96F9@dominion.thruhere.net>
On Thu, 2011-12-01 at 15:58 +0100, Koen Kooi wrote:
> Op 1 dec. 2011, om 14:01 heeft Richard Purdie het volgende geschreven:
>
> > On Wed, 2011-11-30 at 19:15 +0100, Koen Kooi wrote:
> >> Op 30 nov. 2011, om 18:52 heeft Richard Purdie het volgende geschreven:
> >>
> >>> On Wed, 2011-11-30 at 14:40 +0100, Koen Kooi wrote:
> >>>> Upstream has grown cmake support which would allow us to dump the OE
> >>>> autotools hack, but the cmakefile doesn't install the .pc file either
> >>>> and breaks with zlib-native
> >>>>
> >>>> Also remove unused site config file
> >>>
> >>> How did you determine this was unused?
> >>
> >> By removing it and rebuilding zlib(-native) and zlib dependant apps.
> >> In case it does turn out to be needed we should switch to cmake. I'm
> >> OK with having a OE hack for autotools, but a broken OE hack....
> >
> > I don't think you understand what that site_config file triggers. It
> > triggers code in siteconfig.bbclass which saves the *results* of the
> > zlib configure for use in speeding up subsequent configure tasks.
> >
> > Does that change the need to remove it?
>
> I honestly don't know, I've never dealt with that part of siteconfig.
> If the file is needed I'll gladly respin the patch.
That file does make sense so please do :)
Cheers,
Richard
prev parent reply other threads:[~2011-12-01 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 13:40 [PATCH] zlib 1.2.5: install pkgconfig file, needed for e.g. modern webkit Koen Kooi
2011-11-30 17:52 ` Richard Purdie
2011-11-30 18:15 ` Koen Kooi
2011-12-01 13:01 ` Richard Purdie
2011-12-01 14:58 ` Koen Kooi
2011-12-01 15:45 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322754351.17484.138.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox