From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] bootimage: Use ${S} explicitly for generated config files
Date: Fri, 02 Dec 2011 15:29:01 +0000 [thread overview]
Message-ID: <1322839741.18900.31.camel@ted> (raw)
In-Reply-To: <4ef49c1f45f1d61be02121e755546ca10e4668a1.1322795646.git.dvhart@linux.intel.com>
On Thu, 2011-12-01 at 19:20 -0800, Darren Hart wrote:
> The syslinux and grub-efi classes were generating config files in the current
> working directory. This caused a failure due to a race in the creation of the
> directories leading to cwd changing and the build failing to find the config
> files. While this has been addressed in bitbake, it is better to use an
> explicit path.
>
> While ${WORKDIR} may seem a more appropriate place, the recipe
> already uses ${S} for the "hdd" and "cd" construction, so we use ${S}
> here to keep things consolidated and consistent and address the issue
> with minimal change.
>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> ---
> meta/classes/grub-efi.bbclass | 8 +++-----
> meta/classes/syslinux.bbclass | 4 ++--
> 2 files changed, 5 insertions(+), 7 deletions(-)
Merged to master, thanks.
Richard
prev parent reply other threads:[~2011-12-02 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 3:20 [PATCH 0/1] Use ${S} explicitly for generated config files Darren Hart
2011-12-02 3:20 ` [PATCH 1/1] bootimage: " Darren Hart
2011-12-02 15:29 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322839741.18900.31.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox