From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RYDiq-0005SQ-LZ for openembedded-core@lists.openembedded.org; Wed, 07 Dec 2011 10:23:28 +0100 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id pB79Gded012111; Wed, 7 Dec 2011 09:16:39 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 11271-06; Wed, 7 Dec 2011 09:16:35 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id pB79GVNi012105 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 7 Dec 2011 09:16:33 GMT Message-ID: <1323249403.19363.66.camel@ted> From: Richard Purdie To: ulf@emagii.com, Patches and discussions about the oe-core layer Date: Wed, 07 Dec 2011 09:16:43 +0000 In-Reply-To: <4EDF2360.7090402@emagii.com> References: <4EDF2360.7090402@emagii.com> X-Mailer: Evolution 3.2.1- Mime-Version: 1.0 X-Virus-Scanned: amavisd-new at rpsys.net Subject: Re: Possible stale tags in the download directory X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2011 09:23:28 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2011-12-07 at 09:27 +0100, Ulf Samuelsson wrote: > When I look at the "downloads" location I find a lot of files called. > > "11_usagi_fix.patch.done" > > but no "11_usagi_fix.patch" file in the directory. > > If this is a indication of that a patch has been downloaded, > what happens if you for some reason or other delete your > OE-core directory and keep the downloads directory. > > When you start from fresh, all the tags are then stale. > > (Deleting the "downloads" directory seems a bad idea) > > I think that if there should be tags in the "downloads" directory, > they should only reflect things which are downloaded to the > "downloads" directory, and nothing else. > > As for the tags in the directory, I think a better approach > is to download a file "tarball.tar.bz2" to a different filename first > I.E: "tarball.tar.bz2.in-progress" and if the download completes > then move the file to "tarball.tar.bz2". > Should remove a lot of clutter from the "downloads" directory. What we've tried to do is simplify the fetcher code paths in fetch2. There were some many corner/special cases and different code paths it was near impossible to tell what was going on. One of the side effects is that local file:// urls do touch the done stamp in the same way as other downloads. The main reason for those files is now checksum tracking. If the done stamps were part of tmpdir, we'd keep checksumming the contents of the downloads at each build rather than once after the download. The way the implementation works, there is very little risk from stale stamps, it would just mean the checksum code wouldn't get triggered and that is likely unneeded for a local file:// url anyway. So yes, its not ideal but looking at the code I'd be surprised if a build ever broke due to it. Cheers, Richard