From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 07/10] pango: add directfb DISTRO_FEATURE
Date: Wed, 07 Dec 2011 10:27:22 +0000 [thread overview]
Message-ID: <1323253643.26081.311.camel@phil-desktop> (raw)
In-Reply-To: <697ca68b7e47d0392273fa5a07df0e4396e709bf.1323246565.git.xiaofeng.yan@windriver.com>
On Wed, 2011-12-07 at 16:58 +0800, Xiaofeng Yan wrote:
> +PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)}"
> +PACKAGECONFIG[x11] = "--with-x,--without-x,${X11DEPENDS}"
> +PACKAGECONFIG[directfb] = ",,directfb"
Hm, really? I didn't think pango had any inbuilt support for DirectFB.
Does this really accomplish anything?
> + [ ! -d "/etc/pango" ] && mkdir -p /etc/pango/
That will fail with a read-only rootfs, and I think it will also give an
error if /etc/pango already exists. It would be better to just ship
this directory in the package. (Also, it should be ${sysconfdir}.)
p.
next prev parent reply other threads:[~2011-12-07 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 8:58 [PATCH 00/10]gtk+-directfb: The patches to run gtk over directfb Xiaofeng Yan
2011-12-07 8:58 ` [PATCH 01/10] qemu-config: Disable dbus-x11 when no x11 in DISTRO_FEATURES Xiaofeng Yan
2011-12-07 8:58 ` [PATCH 02/10] gconf: Disable dbus-x11 when x11 isn't " Xiaofeng Yan
2011-12-07 8:58 ` [PATCH 03/10] gtk.inc: ship gtk-demo to independent package Xiaofeng Yan
2011-12-07 8:58 ` [PATCH 04/10] gtk.inc: add feature based on directfb Xiaofeng Yan
2011-12-07 9:04 ` Koen Kooi
2011-12-07 8:58 ` [PATCH 05/10] gtk: add demos to the configuation of gtk+ Xiaofeng Yan
2011-12-07 8:58 ` [PATCH 06/10] cairo: add directfb DISTRO_FEATURE Xiaofeng Yan
2011-12-07 8:58 ` [PATCH 07/10] pango: " Xiaofeng Yan
2011-12-07 10:27 ` Phil Blundell [this message]
2011-12-08 7:37 ` Xiaofeng Yan
2011-12-08 9:55 ` Phil Blundell
2011-12-07 8:58 ` [PATCH 08/10] directfb-examples: add package directfb-examples to OE-core Xiaofeng Yan
2011-12-07 8:58 ` [PATCH 09/10] task-core-gtk-directfb.bb: Add task list to run gtk over directfb Xiaofeng Yan
2011-12-07 8:58 ` [PATCH 10/10] core-image-gtk-directfb.bb: add an image for " Xiaofeng Yan
2011-12-08 15:29 ` [PATCH 00/10]gtk+-directfb: The patches to run " Phil Blundell
2011-12-08 23:41 ` Richard Purdie
-- strict thread matches above, loose matches on Subject: below --
2011-12-08 9:33 [PATCH 00/10] gtk+-directfb: " Xiaofeng Yan
2011-12-08 9:34 ` [PATCH 07/10] pango: add directfb DISTRO_FEATURE Xiaofeng Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323253643.26081.311.camel@phil-desktop \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox