Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 6/8] [YOCTO #1776] license: manifest and license path
Date: Fri, 09 Dec 2011 13:30:28 +0000	[thread overview]
Message-ID: <1323437428.5309.154.camel@ted> (raw)
In-Reply-To: <b3e01cfa4f1561a77b07e3365459e9498d8c4585.1323286080.git.elizabeth.flanagan@intel.com>

On Wed, 2011-12-07 at 11:34 -0800, Beth Flanagan wrote:
> +
> +license_create_manifest() {
> +    mkdir -p ${LICENSE_DIRECTORY}/${IMAGE_NAME}
> +    # Get list of installed packages
> +    list_installed_packages | grep -v "locale" |sort > ${LICENSE_DIRECTORY}/${IMAGE_NAME}/package.manifest
> +    INSTALLED_PKGS=`cat ${LICENSE_DIRECTORY}/${IMAGE_NAME}/package.manifest`
> +    # list of installed packages is broken for deb
> +    if [ ${IMAGE_PKGTYPE} != "deb" ]; then
> +
> +        for pkg in ${INSTALLED_PKGS}; do
> +            # not the best way to do this but licenses are not arch dependant iirc
> +            files=`find ${TMPDIR}/pkgdata/*/runtime -name ${pkg}| head -1`
> +            for filename in $files; do
> +                pkged_pn="$(sed -n 's/^PN: //p' ${filename})"
> +                pkged_lic="$(sed -n '/^LICENSE: /{ s/^LICENSE: //; s/[+|&()*]/ /g; s/  */ /g; p }' ${filename})"
> +                # check to see if the package name exists in the manifest. if so, bail.
> +                if ! grep -q "PACKAGE NAME: ${pkg}" ${filename}; then
> +                    # exclude local recipes
> +                    if [ ! ${pkged_pn} == "*locale*" ]; then

The above line is a bashism and is breaking builds with dash
as /bin/sh :(

Cheers,

Richard




  reply	other threads:[~2011-12-09 13:37 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-07 19:34 [PATCH 0/8] License Consolidated Pull Beth Flanagan
2011-12-07 19:34 ` [PATCH 1/8] oe.test_types: move into an oe.tests package Beth Flanagan
2011-12-07 19:34 ` [PATCH 2/8] license: split license parsing into oe.license Beth Flanagan
2011-12-07 19:34 ` [PATCH 3/8] oe.license: add license flattening code Beth Flanagan
2011-12-07 19:34 ` [PATCH 4/8] Add copyleft compliance class Beth Flanagan
2011-12-07 21:53   ` Khem Raj
2011-12-07 22:50     ` Chris Larson
2011-12-09  2:21     ` [PATCH 4/8] Add copyleft compliance class --- MAJOR BREAKAGE!!!! Ulf Samuelsson
2011-12-09  8:24       ` Ulf Samuelsson
2011-12-09 11:45       ` Richard Purdie
2011-12-09 13:46         ` Ulf Samuelsson
2011-12-09 13:51           ` Koen Kooi
2011-12-09 20:03             ` Flanagan, Elizabeth
2011-12-09 19:53           ` Khem Raj
2011-12-07 19:34 ` [PATCH 5/8] gettext-minimal-native: Fix License Beth Flanagan
2011-12-07 19:34 ` [PATCH 6/8] [YOCTO #1776] license: manifest and license path Beth Flanagan
2011-12-09 13:30   ` Richard Purdie [this message]
2011-12-09 19:57     ` Khem Raj
2011-12-09 20:02       ` Joshua Lock
2011-12-09 21:41         ` Khem Raj
2011-12-09 23:49       ` Richard Purdie
2011-12-10  8:16       ` Koen Kooi
2011-12-10 10:29         ` Richard Purdie
2011-12-07 19:34 ` [PATCH 7/8] OECore license fixes: meta/* Beth Flanagan
2011-12-07 21:16   ` Abbreviation of OpenEmbedded-Core (was: [PATCH 7/8] OECore license fixes: meta/*) Paul Menzel
2011-12-07 21:30     ` Abbreviation of OpenEmbedded-Core Joshua Lock
2011-12-07 21:40       ` Paul Menzel
2011-12-14 16:06   ` [PATCH 7/8] OECore license fixes: meta/* Phil Blundell
2011-12-15  1:18     ` Flanagan, Elizabeth
2012-10-02 10:46   ` Phil Blundell
2012-10-02 15:16     ` Flanagan, Elizabeth
2012-10-02 16:00       ` Phil Blundell
2011-12-07 19:34 ` [PATCH 8/8] package.bbclass: Adding license collection Beth Flanagan
2011-12-08 15:25 ` [PATCH 0/8] License Consolidated Pull Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323437428.5309.154.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox