Re: [PATCH] connman: update to 0.78

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2011-12-09 at 10:51 +0000, Otavio Salvador wrote:
> Updates the package to 0.78 bringing changes done on meta-oe to
> OE-Core. This also removes unrequired build-depends and makes the
> package to respect wifi and bluetooth distro features.
> 
> Following patches were removed:
> 
>  * xtables_version.patch: merged upstream
> 
>  * dbusperms.patch: dropped in favour of using sed to make the change
>    in do_compile_append
> 
> Another important change is the addition of ppp in depends that is
> used by some plugins.
> 
> This uses PR as "r1" since it was previously available on meta-oe.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Acked-by: Joshua Lock <josh@linux.intel.com>

This patch appears to:

a) Remove multilib support from the recipe
b) Drop the git version of the recipe (no mention of this above?)
c) Add a pointless rdepends = d.getVar( "RDEPENDS_%s" % package)
d) Remove the dnsproxy, dhclient and test options
e) Add the tools, fake and ntpd options
f) Reorder variables in the file so as to make the diff unreadable and 
   hard to review
g) Change the contents of the ${PN}-scripts package
h) Add tools and tests packages
i) Add a dependeny on ntp
j) Uses bitbake master funtionality (d.expand()) which will break on
older versions of bitbake (we need to increase the bitbake minimum
version)
k) Drops the python scripts dependency

So all things considered, this kind of change is a nightmare to review
in this form and the commit message only covers half the changes it
makes. We need to do better than this...

Cheers,

Richard