Re: [PATCH] gcc-4.6: Let G++ relocate gxx-include-dir when using --sysroot option

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2011-12-14 at 07:49 -0800, Khem Raj wrote:
> On Wed, Dec 14, 2011 at 2:02 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > Hi Khem,
> >
> > What's puzzling me is that reading through this patch, we already do
> > what this patch is doing?
> >
> > Where is the difference which this patch is fixing?
> >
> 
> this does essentially what we were doing earlier but this one is going
> to go upstream

Yes, that is good and I'm fine with the patch for that reason.

> 
> > I appreciate that patch adds in the prefix to the --with-gxx-include-dir
> > option but it then removes it again during configure so this should be a
> > null op. Both versions of the patch set the "1" bit in gcc/cppdefault.c.
> >
> > So where is the change this patch makes which fixes things?
> 
> changing --with-gxx-include-dir to be within sysroot triggers the
> relocation code.

But we were already triggering the relocation code?

I can't see *any* functionality difference between these, they should
both just give the same result as far as I can tell...

Claiming it fixes things is therefore concerning me.

Cheers,

Richard