Re: [PATCH 4/9] consolekit: fix sdk generation issues

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2011-12-16 at 20:07 +0400, Dmitry Eremin-Solenikov wrote:
> On 12/16/2011 07:25 PM, Richard Purdie wrote:
> > On Fri, 2011-12-16 at 16:42 +0400, Dmitry Eremin-Solenikov wrote:
> >> On 12/15/2011 08:20 PM, Cui, Dexuan wrote:
> >>> Richard Purdie wrote on 2011-12-15:
> >>>> On Tue, 2011-12-13 at 20:19 +0400, Dmitry Eremin-Solenikov wrote:
> >>>>> Currently sdk generation might fail with the following error:
> >>>>> | Collected errors:
> >>>>> |  * extract_archive: Cannot create symlink from ./var/log to
> >>>>> 'volatile/log': File exists.
> >>>>> ERROR: Function 'do_populate_sdk' failed
> >>>>>
> >>>>> This happens as consolekit package will include both
> >>>>> /var/log/ConsoleKit and /var/volatile/log/ConsoleKit files:
> >>>>> lumag@fangorn:~/OE-scripts$ dpkg-deb -c
> >>>> build/tmp--eglibc/deploy/ipk/core2/consolekit_0.4.5-r7_core2.ipk  |
> >>>> grep var
> >>>>> drwxr-xr-x root/root         0 2011-12-07 22:12 ./var/ drwxr-xr-x
> >>>>> root/root         0 2011-12-07 22:12 ./var/log/ drwxr-xr-x root/root
> >>>>>        0 2011-12-07 22:12 ./var/log/ConsoleKit/ lrwxrwxrwx root/root
> >>>>>      0 2011-12-07 22:12 ./var/run ->   volatile/run drwxr-xr-x root/root
> >>>>>        0 2011-12-07 22:12 ./var/volatile/ drwxr-xr-x root/root         0
> >>>>> 2011-12-07 22:12 ./var/volatile/log/ drwxr-xr-x root/root         0
> >>>>> 2011-12-07 22:12 ./var/volatile/log/ConsoleKit/ drwxr-xr-x root/root
> >>>>>        0 2011-12-07 22:12 ./var/volatile/run/ drwxr-xr-x root/root
> >>>>>    0 2011-12-07 22:12 ./var/volatile/run/ConsoleKit/
> >>>>>
> >>>>> Inclusion of both log directories causes this error. Drop the
> >>>>> /var/log/ConsoleKit in favour of /var/volatile/log
> >>> Hi Dmitry,
> >>> Could you please explain how and where the extract_archive error is caused?
> >>> Where is /var/log linked to /var/volatile/log?
> >>
> >> I have tried building meta-toolchain-qte... and I got exactly the error
> >> from my original message.
> >>
> >>>
> >>> Do you mean RP's patch "consolekit: Fix ${localstatedir} race" didn't fix the issue?
> >>> (I suspect so)
> >>
> >> Yes, I still had the issues even after PR's patch.
> >>
> >>>
> >>>> This effectively reverts:
> >>>> http://git.openembedded.org/openembedded-core/commit/?id=5608a748
> >>>> af2c754f60137ab7c3010ccce6bf9e40 so I think this fixes one problem at
> >>>> the expense of causing another. Koen: Any comments?
> >>>
> >>> Thanks,
> >>> -- Dexuan
> >
> > I believe this is an installation ordering problem in opkg. If you apply
> > my opkg patch (and the nativesdk one I just posted), I don't see this
> > problem with meta-toolchain-gmae.
> 
> I still see one problem. Without my patch I have both 
> /var/volatile/log/ConsoleKit and /var/log/ConsoleKit in consolekit 
> package. Won't that cause troubles?

No, that wasn't the problem opkg was reporting. The problem opkg was
reporting was that base-files hadn't installed first and its responsible
for setting up the var symlinks.

Cheers,

Richard