From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [RFC PATCH 0/1] Locale package installation
Date: Wed, 04 Jan 2012 11:17:23 +0000 [thread overview]
Message-ID: <1325675843.3555.125.camel@ted> (raw)
In-Reply-To: <2101328.0yZ7sRDDBg@helios>
On Wed, 2012-01-04 at 00:50 +0000, Paul Eggleton wrote:
> On Tuesday 03 January 2012 15:54:12 Saul Wold wrote:
> > On 12/28/2011 05:43 AM, Paul Eggleton wrote:
> > > Implement locale package installation as we had in OE-Classic; please
> > > review. In particular I'm not sure of the naming of
> > > rootfs_check_package_exists() (since it resolves the package to a
> > > filename in the case of RPM). Note that because of the default value of
> > > IMAGE_LINGUAS this patch will result in images growing slightly.
> >
> > Merged into OE-Core
>
> Er, this was actually an RFC patch and I was hoping to get some more review
> and comments especially as it came during the holidays...
>
> It may be too late to stop it going in but if anyone has any comments/issues
> please raise them now and we can look at further patches if necessary.
To be honest, I'm not happy with the current rootfs/package code as
there are way too many differences between the backends and too much
duplicated code. Its heading towards being an unmaintainable mess.
Your patch starts to unwind some of that so as far as I'm concerned that
is a good thing. I'd not realised it was an RFC when it was presented as
part of the consolidated pull but I think its a good thing to have in.
I'd really like to see more patches like that one.
Cheers,
Richard
prev parent reply other threads:[~2012-01-04 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 13:43 [RFC PATCH 0/1] Locale package installation Paul Eggleton
2011-12-28 13:43 ` [RFC PATCH 1/1] classes/image: implement generic locale " Paul Eggleton
2012-01-03 23:54 ` [RFC PATCH 0/1] Locale " Saul Wold
2012-01-04 0:50 ` Paul Eggleton
2012-01-04 11:17 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325675843.3555.125.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox