Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image_types: Ensure /init exists for cpio rootfs archives
Date: Thu, 05 Jan 2012 12:30:15 +0000	[thread overview]
Message-ID: <1325766615.20759.67.camel@ted> (raw)
In-Reply-To: <CAAQYJAvu-n9eyXV8kj3=34_wzhdfec5Nit9uUy_ar=jFK1tFaQ@mail.gmail.com>

On Thu, 2012-01-05 at 01:05 +0100, Andrea Adami wrote:
> I'd say we have to test for the in-existence of the file instead of
> blindly touching it.
> Smthg like
> 
> if [! -e ${IMAGE_ROOTFS}/init]; then
> touch ${IMAGE_ROOTFS}/init
> fi
> 
> 
> Now, repeating that block for all 4 cpio images is a bit ugly... better ideas?

Make it a shell function we call? I'd also check for
${base_sbindir}/init first too?

Cheers,

Richard




  reply	other threads:[~2012-01-05 12:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fbed4e9f94ed9bd1bb5a9c8fa37113e325f89371.1325115602.git.dvhart@linux.intel.com>
2011-12-28 23:54 ` [PATCH] image_types: Ensure /init exists for cpio rootfs archives Darren Hart
2011-12-29 17:39   ` Chris Larson
2011-12-30  8:25   ` Andrea Adami
2011-12-30 23:18     ` Darren Hart
2012-01-03 14:57       ` Andrea Adami
2012-01-04  0:07   ` Saul Wold
2012-01-04 23:49     ` Andrea Adami
2012-01-05  0:05       ` Andrea Adami
2012-01-05 12:30         ` Richard Purdie [this message]
2012-01-05 23:36           ` Darren Hart
2012-01-06  1:00             ` Andrea Adami
2012-01-06  1:10               ` Andrea Adami
2012-01-06 10:57               ` Richard Purdie
2012-01-06 22:58                 ` Andrea Adami
2012-01-10 23:07                   ` Andrea Adami
2012-01-10 23:28                     ` Andrea Adami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325766615.20759.67.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox