From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/8] bdwgc: change the PV
Date: Wed, 01 Feb 2012 22:23:50 +0000 [thread overview]
Message-ID: <1328135030.2716.163.camel@x121e.pbcl.net> (raw)
In-Reply-To: <e50f34e22b4a6fd1b7352affb529082c86f946c1.1328133261.git.nitin.a.kamble@intel.com>
On Wed, 2012-02-01 at 13:55 -0800, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
> .../{bdwgc_20110107.bb => bdwgc_7_2alpha5.bb} | 0
Why is this a good thing? Does the "_" in the string actually do what
you wanted?
The commit message for this patch is, to put it mildly, poor. Please
see:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#New_Development
and, in particular the last two sentences of that section:
"It is not acceptable to have an empty or non-existent header, or just a
single line message. The summary and description is required for all
changes."
p.
next prev parent reply other threads:[~2012-02-01 22:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 21:55 [PATCH 0/8] Variosu recipe upgrades nitin.a.kamble
2012-02-01 21:55 ` [PATCH 1/8] byacc: upggrade from 20111219 to 20120115 nitin.a.kamble
2012-02-01 21:55 ` [PATCH 2/8] gmp: upgrade from 5.0.2 to 5.0.3 nitin.a.kamble
2012-02-01 22:02 ` Khem Raj
2012-02-01 23:20 ` Kamble, Nitin A
2012-02-02 5:11 ` Khem Raj
2012-02-01 21:55 ` [PATCH 3/8] bdwgc: change the PV nitin.a.kamble
2012-02-01 22:07 ` Khem Raj
2012-02-01 22:23 ` Phil Blundell [this message]
2012-02-01 23:18 ` Kamble, Nitin A
2012-02-01 21:55 ` [PATCH 4/8] gdb: upgrade from 7.3.1 to 7.4 nitin.a.kamble
2012-02-01 21:55 ` [PATCH 5/8] quilt: upgrade from 0.50 to 0.51 nitin.a.kamble
2012-02-01 21:55 ` [PATCH 6/8] python-dbus: upgrade from 0.84.0 to 1.0.0 nitin.a.kamble
2012-02-01 21:55 ` [PATCH 7/8] linux-libc-headers: new recipes for latest upstream 3.2.2 nitin.a.kamble
2012-02-01 22:14 ` Khem Raj
2012-02-01 23:23 ` Kamble, Nitin A
2012-02-02 1:01 ` Bruce Ashfield
2012-02-02 5:14 ` Khem Raj
2012-02-02 5:58 ` Bruce Ashfield
2012-02-01 21:55 ` [PATCH 8/8] distro_tracking: update for current upgrades nitin.a.kamble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328135030.2716.163.camel@x121e.pbcl.net \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox