From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] dhcp: move dhcp leases files handling to postinst/postrm
Date: Thu, 02 Feb 2012 14:53:49 +0000 [thread overview]
Message-ID: <1328194429.13744.187.camel@ted> (raw)
In-Reply-To: <1328179437.29933.185.camel@phil-desktop>
On Thu, 2012-02-02 at 10:43 +0000, Phil Blundell wrote:
> On Wed, 2012-02-01 at 19:01 -0200, Otavio Salvador wrote:
> > On Wed, Feb 1, 2012 at 18:57, Phil Blundell <philb@gnu.org> wrote:
> > On Wed, 2012-02-01 at 20:27 +0000, Otavio Salvador wrote:
> > > pkg_postinst_dhcp-server() {
> > > + install -d $D/${localstatedir}/lib/dhcp
> >
> >
> > Is "install" guaranteed to be available on the target? I
> > would have
> > thought "mkdir -p" would be better.
> >
> >
> > It worked on all images I tested. I have no strong opinions about it.
>
> I just checked a rootfs that I happened to have lying around and there
> was indeed no "install" binary in there. Admittedly I always build with
> O_P_M=none so it isn't going to cause me any real problem, but
> presumably there might be other folks who have O_P_M on and still lack
> "install". So I think it would be best to change this.
Agreed, mkdir is much more likely to be available than install on most
target machines.
Cheers,
Richard
next prev parent reply other threads:[~2012-02-02 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 20:27 [PATCH 0/3] Pending patches in O.S. Systems tree Otavio Salvador
2012-02-01 20:27 ` [PATCH 1/3] udev: improve udev-cache robustness Otavio Salvador
2012-02-01 20:52 ` Otavio Salvador
2012-02-01 20:27 ` [PATCH 2/3] dhcp: move dhcp leases files handling to postinst/postrm Otavio Salvador
2012-02-01 20:57 ` Phil Blundell
2012-02-01 21:01 ` Otavio Salvador
2012-02-02 10:43 ` Phil Blundell
2012-02-02 14:53 ` Richard Purdie [this message]
2012-02-02 18:34 ` Otavio Salvador
2012-02-01 20:27 ` [PATCH 3/3] rootfs_ipk.bbclass: fix detection of script runtime requirement Otavio Salvador
2012-02-01 20:59 ` Phil Blundell
2012-02-01 21:03 ` Otavio Salvador
2012-02-02 10:42 ` Phil Blundell
2012-02-02 8:48 ` Martin Jansa
2012-02-02 14:57 ` [PATCH 0/3] Pending patches in O.S. Systems tree Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328194429.13744.187.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox