Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package.bbclass: Optimise the per file rpm handling
Date: Fri, 10 Feb 2012 13:39:12 +0000	[thread overview]
Message-ID: <1328881152.13434.9.camel@ted> (raw)
In-Reply-To: <4F347F9A.5090007@linux.intel.com>

On Thu, 2012-02-09 at 18:23 -0800, Joshua Lock wrote:
> On 09/02/12 16:10, Richard Purdie wrote:
> > Currently a process was being forked off for each individual file
> > this class wanted to inspect with rpmdeps. This converts it to use
> > rpmdeps-oecore which allows batch processing of these dependencies.
> >
> > For do_package for perl, this reduced the time by about 1 minute (33%).
> 
> Awesome! Sounds like this addresses #1718
> 
> http://bugzilla.pokylinux.org/show_bug.cgi?id=1718

It will certainly help with that issue, yes.

> > @@ -1136,7 +1136,7 @@ RPMDEPS = "${STAGING_LIBDIR_NATIVE}/rpm/bin/rpmdeps --macros ${STAGING_LIBDIR_NA
> >   #  FILERDEPENDS_filepath_pkg - per file dep
> >
> >   python package_do_filedeps() {
> > -	import os, re
> > +	import re, subprocess
> 
> Was this accidentally left in? I don't see any calls to subprocess?

It was indeed from a different experiment, well spotted. I've removed
that.

Cheers,

Richard




      reply	other threads:[~2012-02-10 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10  0:10 [PATCH] package.bbclass: Optimise the per file rpm handling Richard Purdie
2012-02-10  2:23 ` Joshua Lock
2012-02-10 13:39   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328881152.13434.9.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox