From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/4] gdb-cross-canadian: use NATIVESDK paths as it happens to be here
Date: Sat, 18 Feb 2012 14:01:06 +0000 [thread overview]
Message-ID: <1329573666.1884.5.camel@ted> (raw)
In-Reply-To: <20120218115651.GA11351@jama.jama.net>
On Sat, 2012-02-18 at 12:56 +0100, Martin Jansa wrote:
> On Fri, Feb 17, 2012 at 02:36:48PM -0800, Saul Wold wrote:
> > On 02/13/2012 07:40 AM, Martin Jansa wrote:
> > > * seems like config/config in -L was also wrong
> > >
> > > Signed-off-by: Martin Jansa<Martin.Jansa@gmail.com>
> > > ---
> > > meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 10 ++++++++--
> > > 1 files changed, 8 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > index b5746ce..bac63b7 100644
> > > --- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
> > > @@ -10,12 +10,18 @@ RDEPENDS += "python-nativesdk-core python-nativesdk-lang python-nativesdk-re \
> > >
> > > EXTRA_OECONF_append = "--with-python=${WORKDIR}/python"
> > >
> > > +NATIVESDK_NAME = "oecore-${SDK_ARCH}-${SDK_ARCH}"
> > > +NATIVESDK_PATH = "/usr/local/${NATIVESDK_NAME}"
>
> Ah, I was reusing definition from bitbake.conf:
> meta/conf/bitbake.conf:SDK_NAME = "oecore-${SDK_ARCH}-${TARGET_ARCH}"
>
> with only TARGET_ARCH replaced with SDK_ARCH.
>
> Can we move "oecore" to extra varible like:
>
> bitbake.conf:
> -SDK_NAME = "oecore-${SDK_ARCH}-${TARGET_ARCH}"
> +SDK_NAME_PREFIX = "oecore"
> +SDK_NAME = "${SDK_NAME_PREFIX}-${SDK_ARCH}-${TARGET_ARCH}"
>
> meta-yocto/conf/distro/poky.conf:
> -SDK_NAME = "${DISTRO}-${TCLIBC}-${SDK_ARCH}-${TARGET_ARCH}"
> +SDK_NAME_PREFIX = "${DISTRO}-${TCLIBC}"
>
> SDK_PATH is worse:
> meta/conf/bitbake.conf:SDKPATH = "/usr/local/${SDK_NAME}"
> meta-yocto/conf/distro/poky.conf:SDKPATH = "/opt/${DISTRO}/${SDK_VERSION}"
>
> Maybe this patch is not going in right direction, but nobody replied in
> "SDK confusion Was: [oe] [meta-oe] gdb-cross-canadian: build gdb with python support"
> thread so I have sent this version which works in default (distroless)
> oe-core (and also for SHR as we don't override default SDK* variables.
This last week has been a bit problematic with conference activities
occupying many of the people who would normally have replied to that
kind of thread.
I'm very worried that you're having to copy the base bitbake definitions
as needing to do that is usually a sign there is some underlying more
fundamental problem. We really need to find a better alternative.
I therefore don't think the patch as it stands can go in but I do want
to understand the problem and try and fix it in a way that addresses the
issues. I'm probably not going to get a chance to look at things until
next week though.
Cheers,
Richard
next prev parent reply other threads:[~2012-02-18 14:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 15:40 [PATCH 0/4] PR bumps for missing libz.la, resent gdb python support with fix Martin Jansa
2012-02-13 15:40 ` [PATCH 1/4] gdb-cross-canadian: build gdb with python support Martin Jansa
2012-02-13 15:40 ` [PATCH 2/4] gdb-cross-canadian: use NATIVESDK paths as it happens to be here Martin Jansa
2012-02-13 16:11 ` [PATCH] gdb-cross-canadian: bump PR Martin Jansa
2012-02-17 22:36 ` [PATCH 2/4] gdb-cross-canadian: use NATIVESDK paths as it happens to be here Saul Wold
2012-02-18 11:56 ` Martin Jansa
2012-02-18 14:01 ` Richard Purdie [this message]
2012-02-23 8:16 ` Martin Jansa
2012-02-23 10:27 ` Richard Purdie
2012-02-25 0:05 ` Martin Jansa
2012-02-25 1:02 ` Richard Purdie
2012-02-25 13:12 ` Martin Jansa
2012-02-25 15:42 ` Richard Purdie
2012-02-13 15:40 ` [PATCH 3/4] zlib: remove ldconfig call from install-libs Martin Jansa
2012-02-13 15:40 ` [PATCH 4/4] recipes: bump PR to rebuild .la files without libz.la Martin Jansa
2012-02-21 19:00 ` Steve Sakoman
2012-02-21 19:25 ` Steve Sakoman
2012-02-21 21:07 ` Khem Raj
2012-02-21 21:16 ` Steve Sakoman
2012-02-21 21:33 ` Phil Blundell
2012-02-21 21:39 ` Steve Sakoman
2012-02-21 21:45 ` Phil Blundell
2012-02-21 21:44 ` Paul Eggleton
2012-02-21 22:01 ` Steve Sakoman
2012-02-21 17:07 ` [PATCH 0/4] PR bumps for missing libz.la, resent gdb python support with fix Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329573666.1884.5.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox