Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] initscripts: Make /etc/timestamp consistent again.
Date: Fri, 24 Feb 2012 10:26:26 +0000	[thread overview]
Message-ID: <1330079186.32006.4.camel@ted> (raw)
In-Reply-To: <4F473702.7020909@bluegiga.com>

On Fri, 2012-02-24 at 09:06 +0200, Lauri Hintsala wrote:
> On 02/10/2012 06:16 PM, Gary Thomas wrote:
> > Commit cc8695 changed the way timestamps were handled
> > and added some extra munging to be able to compare them
> > reliably.  This change makes the timestamp value the same
> > everywhere and simplifies how the check to set the system
> > clock based on the timestamp is done.
> >
> > Also, if the value stored in /etc/timestamp is newer
> > [at all] than the current system time, set the system clock
> > from the stored value, down to the minute, not just the day.
> >
> > Signed-off-by: Gary Thomas<gary@mlbassoc.com>
> > ---
> >   .../initscripts/initscripts-1.0/bootmisc.sh        |    4 ++--
> >   .../initscripts/initscripts-1.0/save-rtc.sh        |    2 +-
> >   meta/recipes-core/initscripts/initscripts_1.0.bb   |    2 +-
> >   3 files changed, 4 insertions(+), 4 deletions(-)
> 
> 
> Hi Gary,
> 
> You should do the same changes to meta/classes/image.bbclass where the 
> /etc/timestamp file is generated to filesystem image.

Agreed, this is a nasty inconsistency. I've pushed a patch into master
which fixes this.

Cheers,

Richard




  reply	other threads:[~2012-02-24 10:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 16:16 [PATCH] initscripts: Make /etc/timestamp consistent again Gary Thomas
2012-02-24  7:06 ` Lauri Hintsala
2012-02-24 10:26   ` Richard Purdie [this message]
2012-02-24 18:31 ` Saul Wold
2012-02-29  5:31   ` James Limbouris
2012-02-29  6:34   ` James Limbouris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330079186.32006.4.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox